Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an end-to-end test for the NACK sender. #2984

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

jech
Copy link
Member

@jech jech commented Jan 2, 2025

End-to-end test for the NACK sending interceptor. It notably tests negotiation. See the function comment for details.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.87%. Comparing base (92d573c) to head (3b2ae1f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2984      +/-   ##
==========================================
- Coverage   77.88%   77.87%   -0.01%     
==========================================
  Files          89       89              
  Lines       10524    10524              
==========================================
- Hits         8197     8196       -1     
  Misses       1838     1838              
- Partials      489      490       +1     
Flag Coverage Δ
go 79.45% <ø> (-0.02%) ⬇️
wasm 63.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jech jech force-pushed the nack-test branch 7 times, most recently from 61bab23 to 64e4940 Compare January 2, 2025 13:42
Test that NACKs are negotiated correctly, and that we receive
the expected NACK if we negotiated it.
@jech jech merged commit 92fce5f into pion:master Jan 2, 2025
17 checks passed
@jech jech deleted the nack-test branch January 2, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants