Add EnableDataChannelBlockWrite to SettingEngine #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2968 +/- ##
==========================================
+ Coverage 77.73% 77.79% +0.05%
==========================================
Files 89 89
Lines 10521 10526 +5
==========================================
+ Hits 8179 8189 +10
+ Misses 1850 1845 -5
Partials 492 492
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cnderrauber
force-pushed
the
dc_nonblock_write
branch
from
ffe4531 to
a81adc8
Compare
The API check complains compatibility issues but they should be ok for existed codes, any suggestion on this change? @Sean-Der |
cnderrauber
force-pushed
the
dc_nonblock_write
branch
from
a81adc8 to
83fc858
Compare
cnderrauber
force-pushed
the
dc_nonblock_write
branch
from
83fc858 to
d3740eb
Compare
|
@cnderrauber Could we do API break I believe could be a problem. Users could have code that returns a |
The settingengine can enabled block write if datachannel is detached, makes it working like a normal net.Conn.
cnderrauber
force-pushed
the
dc_nonblock_write
branch
from
d3740eb to
1875e19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settingengine can enabled block write if
datachannel is detached, makes it working like
a normal net.Conn.
Description
Reference issue
Fixes #...