Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Mux logging on Close #2901

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Reduce Mux logging on Close #2901

merged 2 commits into from
Sep 10, 2024

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Sep 9, 2024

This removes warning logs like:

Warning: mux: no endpoint for packet starting with 21

when closing the connection.

Replace RWMutex with Mutex because there's only 1 goroutine reading.

We only read from one goroutine, the RWMutex doesn't help improve
performance in this case
@sukunrt sukunrt requested review from Sean-Der and edaniels September 9, 2024 15:10
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.92%. Comparing base (e6a86e7) to head (7869792).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2901      +/-   ##
==========================================
- Coverage   78.94%   78.92%   -0.03%     
==========================================
  Files          89       89              
  Lines        8488     8489       +1     
==========================================
- Hits         6701     6700       -1     
- Misses       1299     1301       +2     
  Partials      488      488              
Flag Coverage Δ
go 80.48% <100.00%> (-0.03%) ⬇️
wasm 65.12% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@edaniels edaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@sukunrt sukunrt merged commit 28adb77 into master Sep 10, 2024
18 checks passed
@sukunrt sukunrt deleted the sukun/mux-logging-2 branch September 10, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants