Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide SCTP Association OnClose callback #2861

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Provide SCTP Association OnClose callback #2861

merged 2 commits into from
Aug 13, 2024

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Aug 12, 2024

Porting #2858 to v3.

@sukunrt sukunrt requested review from Sean-Der and MarcoPolo August 12, 2024 16:48
sukunrt added a commit to libp2p/go-libp2p that referenced this pull request Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.19%. Comparing base (4e4a67d) to head (484d89a).

Files Patch % Lines
sctptransport.go 68.75% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2861      +/-   ##
==========================================
- Coverage   80.19%   80.19%   -0.01%     
==========================================
  Files          78       78              
  Lines        7599     7614      +15     
==========================================
+ Hits         6094     6106      +12     
- Misses       1070     1072       +2     
- Partials      435      436       +1     
Flag Coverage Δ
go 80.19% <68.75%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sukunrt sukunrt merged commit cef1db8 into v3 Aug 13, 2024
13 of 14 checks passed
@sukunrt sukunrt deleted the v3-sctp-onclose branch August 13, 2024 15:14
@sukunrt sukunrt mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants