Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: IVF writer writing invalid timestamp value into frame headers #2853

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

radekg
Copy link
Contributor

@radekg radekg commented Aug 4, 2024

Description

This PR fixes the incorrect header timestamp written into the frame headers.

Reference issue

Fixes #2384

@edaniels
Copy link
Member

edaniels commented Aug 4, 2024

Thanks @radekg!

Copy link
Member

@edaniels edaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty for the fix and added test

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.08%. Comparing base (8ec98b7) to head (9202b3c).

Files Patch % Lines
pkg/media/ivfwriter/ivfwriter.go 50.00% 0 Missing and 2 partials ⚠️

❗ There is a different number of reports uploaded between BASE (8ec98b7) and HEAD (9202b3c). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (8ec98b7) HEAD (9202b3c)
go 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2853       +/-   ##
===========================================
- Coverage   78.94%   65.08%   -13.87%     
===========================================
  Files          89       67       -22     
  Lines        8335     3239     -5096     
===========================================
- Hits         6580     2108     -4472     
+ Misses       1278     1005      -273     
+ Partials      477      126      -351     
Flag Coverage Δ
go ?
wasm 65.08% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels
Copy link
Member

edaniels commented Aug 4, 2024

@radekg can you fix up the error from the meta lint (commit message length)?

@radekg radekg force-pushed the fix-ivfwriter-timestamp branch from baf2348 to 33d9460 Compare August 5, 2024 05:29
@radekg radekg force-pushed the fix-ivfwriter-timestamp branch from 33d9460 to 9202b3c Compare August 5, 2024 05:32
@edaniels edaniels merged commit dbe26d3 into pion:master Aug 5, 2024
15 of 17 checks passed
@radekg radekg deleted the fix-ivfwriter-timestamp branch August 5, 2024 15:18
@xdrudis xdrudis mentioned this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

IVF writer writing invalid timestamp value into frame headers?
2 participants