Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestPeerConnection_EventHandlers flake #2849

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Conversation

edaniels
Copy link
Member

@edaniels edaniels commented Aug 2, 2024

This may have originally been needed but it looks like there's nothing preventing connecting -> callback starts -> connected -> callback continues.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.08%. Comparing base (3f2cd52) to head (412310a).

❗ There is a different number of reports uploaded between BASE (3f2cd52) and HEAD (412310a). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (3f2cd52) HEAD (412310a)
go 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2849       +/-   ##
===========================================
- Coverage   78.93%   65.08%   -13.86%     
===========================================
  Files          89       67       -22     
  Lines        8335     3239     -5096     
===========================================
- Hits         6579     2108     -4471     
+ Misses       1279     1005      -274     
+ Partials      477      126      -351     
Flag Coverage Δ
go ?
wasm 65.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels edaniels merged commit 13b4a61 into pion:master Aug 2, 2024
16 of 17 checks passed
@edaniels edaniels deleted the 2848 branch August 2, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

TestPeerConnection_EventHandlers flaky on WASM
2 participants