Close unhandled rtcp simulcast streams #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2826 +/- ##
==========================================
- Coverage 79.01% 78.91% -0.11%
==========================================
Files 89 89
Lines 8292 8303 +11
==========================================
Hits 6552 6552
- Misses 1267 1275 +8
- Partials 473 476 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I noticed the srtcp leaking packetio.buffer's when I added a goroutine to them in pion/transport#304 |
edaniels
commented
Jul 22, 2024
| continue | ||
| } | ||
|
|
||
| pc.dtlsTransport.storeSimulcastStream(srtpReadStream, srtcpReadStream) |
There was a problem hiding this comment.
an observation while working on this: we hang onto these for the lifetime of the PC which could increase memory over time. It would be better to know that these are strictly 1. not valid when expecting simulcast and 2. not valid ssrcs when we are non-simulcast
handleIncomingSSRC will call streamsForSSRC which opens rtp/rtcp streams that if unhandled can be leaked resources. Now we will proactively open them before calling handleIncomingSSRC and close then later. In the future it would be better to do this inside handleIncomingSSRC to protect other callers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handleIncomingSSRC will call streamsForSSRC which opens rtp/rtcp streams that if unhandled can be leaked resources. Now we will proactively open them before calling handleIncomingSSRC and close then later. In the future it would be better to do this inside handleIncomingSSRC to protect other callers.