Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pending queue in mux for dropped packets #2813

Closed
wants to merge 1 commit into from
Closed

Implement pending queue in mux for dropped packets #2813

wants to merge 1 commit into from

Conversation

lactyy
Copy link
Contributor

@lactyy lactyy commented Jul 19, 2024

Description

As explained in this thread on the Gophers Slack, internal/mux needs a pending queue for packets that would be dropped in some ORTC situations (e.g. ICE transport blocks until it is in a connected state, losing any DTLS packets received in the meantime).

Reference issue

N/A

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.04%. Comparing base (b874788) to head (a1c1347).

Files Patch % Lines
internal/mux/mux.go 77.77% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2813      +/-   ##
==========================================
- Coverage   80.68%   79.04%   -1.64%     
==========================================
  Files          78       89      +11     
  Lines        7548     8299     +751     
==========================================
+ Hits         6090     6560     +470     
- Misses       1032     1267     +235     
- Partials      426      472      +46     
Flag Coverage Δ
go 80.65% <77.77%> (-0.04%) ⬇️
wasm 65.05% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lactyy lactyy changed the title Implement pending handler in mux for dropped packets Implement pending queue in mux for dropped packets Jul 19, 2024
@lactyy lactyy closed this Jul 19, 2024
@lactyy lactyy deleted the pending-packets-handler branch July 19, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant