Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove examples/internal #2770

Merged
merged 1 commit into from
May 20, 2024
Merged

Remove examples/internal #2770

merged 1 commit into from
May 20, 2024

Conversation

Sean-Der
Copy link
Member

Users find it frustrating that example code doesn't work out of tree. This makes copying the examples out of the repo easier.

Relates to #1981

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.41%. Comparing base (aa9c623) to head (e0a4d9c).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2770       +/-   ##
===========================================
- Coverage   78.91%   64.41%   -14.50%     
===========================================
  Files          87       65       -22     
  Lines        8208     3164     -5044     
===========================================
- Hits         6477     2038     -4439     
+ Misses       1263      997      -266     
+ Partials      468      129      -339     
Flag Coverage Δ
go ?
wasm 64.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Users find it frustrating that example code doesn't work out of tree.
This makes copying the examples out of the repo easier.

Relates to #1981
@Sean-Der Sean-Der merged commit 09461d5 into master May 20, 2024
17 of 18 checks passed
@Sean-Der Sean-Der deleted the issue-1981 branch May 20, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant