-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
whip/whep example #2708
whip/whep example #2708
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2708 +/- ##
==========================================
- Coverage 76.40% 76.36% -0.05%
==========================================
Files 87 87
Lines 9923 9923
==========================================
- Hits 7582 7578 -4
- Misses 1870 1873 +3
- Partials 471 472 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@Sean-Der Let me know if you'd like to see more implemented. There a a few more status codes and http verbs as part of a full WHIP/WHEP implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Stephan! The code looks clean and simple.
Great work @stephanrotolante ! We should be able to merge this super quick Instead of FFMPEG can we do a flow with OBS? The newest version has WHIP support and is what people want to build with. I think the goal is publish once with OBS then watch unlimited times. |
730ca75
to
3a2d060
Compare
616bc64
to
da3e0c5
Compare
@stephanrotolante I made some changes, mind checking them out? I put
and
Since your name is on the commit mind trying out and make sure you like it/agree with how it all flows? I am going to update the docs tomorrow and merge! |
da3e0c5
to
f3adacc
Compare
Looks good to me! |
@Sean-Der with my readme I added a video (there is no audio), walking through how to use OBS with a WHEP source. You might want to delete that since the api was changed up. It looks like I got WHEP + WHIP mixed up |
Create WHIP/WHEP example works with OBS or browser Resolves pion#2499
f3adacc
to
923541c
Compare
@stephanrotolante Done! Merged into master, great work :) Give it a try and I am sure I made mistakes, please send PRs and will merge them quick! |
Description
Small example of a WHIP/WHEP exchange
Reference issue
resolves #2499