Drop reference to detached datachannels #2696
Merged
+102
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2696 +/- ##
=======================================
Coverage 76.38% 76.39%
=======================================
Files 87 87
Lines 9923 9947 +24
=======================================
+ Hits 7580 7599 +19
- Misses 1871 1875 +4
- Partials 472 473 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sukunrt
force-pushed
the
datachannel-reference
branch
4 times, most recently
from
e2efe0a to
2268938
Compare
MarcoPolo
approved these changes
Mar 12, 2024
| d.sctpTransport.lock.Lock() | ||
| n := len(d.sctpTransport.dataChannels) | ||
| j := 0 | ||
| for i := 0; i < n; i++ { |
There was a problem hiding this comment.
Does d.sctpTransport.dataChannels need to remain in order? Can you swap remove instead?
There was a problem hiding this comment.
I think I can. I just didn't want to change that property here.
|
Thank you so much @sukunrt! Really appreciate the tests :) Rebasing + merging now |
Sean-Der
force-pushed
the
datachannel-reference
branch
from
2268938 to
dff6bcb
Compare
This allows users of detached datachannels to garbage collect resources associated with the datachannel and the sctp stream. There is no functional change here.
Sean-Der
force-pushed
the
datachannel-reference
branch
from
dff6bcb to
2444e36
Compare
Sean-Der
approved these changes
Mar 25, 2024
sukunrt
added a commit
that referenced
this pull request
Dec 23, 2024
#2696 introduced removing datachannels from the sctptransport for better garbage collection. That PR introduced a race condition for data channels created before connection establishment. When an out of band negotiated data channel, created before peerconnection establishment is detached, there's a race between the data channel being removed from `r.dataChannels` and it being copied in to the existing data channel slice in the acceptDataChannels goroutine. This PR fixes this race by copying the slice before any datachannels could be detached.
sukunrt
added a commit
that referenced
this pull request
Dec 24, 2024
#2696 introduced removing datachannels from the sctptransport for better garbage collection. That PR introduced a race condition for data channels created before connection establishment. When an out of band negotiated data channel, created before peerconnection establishment is detached, there's a race between the data channel being removed from `r.dataChannels` and it being copied in to the existing data channel slice in the acceptDataChannels goroutine. This PR fixes this race by copying the slice before any datachannels could be detached.
sukunrt
added a commit
that referenced
this pull request
Dec 24, 2024
#2696 introduced removing datachannels from the sctptransport for better garbage collection. That PR introduced a race condition for data channels created before connection establishment. When an out of band negotiated data channel, created before peerconnection establishment is detached, there's a race between the data channel being removed from `r.dataChannels` and it being copied in to the existing data channel slice in the acceptDataChannels goroutine. This PR fixes this race by copying the slice before any datachannels could be detached.
sukunrt
added a commit
that referenced
this pull request
Dec 24, 2024
#2696 introduced removing datachannels from the sctptransport for better garbage collection. That PR introduced a race condition for data channels created before connection establishment. When an out of band negotiated data channel, created before peerconnection establishment is detached, there's a race between the data channel being removed from `r.dataChannels` and it being copied in to the existing data channel slice in the acceptDataChannels goroutine. This PR fixes this race by copying the slice before any datachannels could be detached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users of detached datachannels to garbage collect resources associated with the datachannel and the sctp stream. There is no functional change here.
Fixes #2672