Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetPackertizer method to TrackLocalStaticSample #2689

Closed
wants to merge 1 commit into from

Conversation

AnshulMalik
Copy link

No description provided.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 76.32%. Comparing base (09a4f60) to head (1f9ef24).

Files Patch % Lines
track_local_static.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2689      +/-   ##
==========================================
- Coverage   76.43%   76.32%   -0.11%     
==========================================
  Files          87       87              
  Lines        9928     9933       +5     
==========================================
- Hits         7588     7581       -7     
- Misses       1869     1879      +10     
- Partials      471      473       +2     
Flag Coverage Δ
go 77.84% <0.00%> (-0.13%) ⬇️
wasm 64.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der
Copy link
Member

Hey @AnshulMalik

This seems find to merge! What use case are you trying to solve? I just want to make sure this is the right API for it.

@Sean-Der
Copy link
Member

I am going to close for now. If you get a chance would love to re-visit this. Thanks @AnshulMalik

@Sean-Der Sean-Der closed this Mar 25, 2024
@Sean-Der Sean-Der deleted the set-packetizer branch March 25, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants