Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interceptor.RTCPReaderFunc typo #2675

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

aggresss
Copy link
Member

Description

Reference issue

Fixes interceptor.RTCPReaderFunc typo
Although interceptor.RTCPReaderFunc and interceptor.RTPReaderFunc have the same signature, at interceptor.BindRTCPReader should use interceptor.RTCPReaderFunc

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc6f9a2) 76.41% compared to head (4eaa997) 76.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2675      +/-   ##
==========================================
- Coverage   76.41%   76.37%   -0.05%     
==========================================
  Files          87       87              
  Lines        9922     9922              
==========================================
- Hits         7582     7578       -4     
- Misses       1870     1872       +2     
- Partials      470      472       +2     
Flag Coverage Δ
go 77.90% <100.00%> (-0.05%) ⬇️
wasm 64.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der
Copy link
Member

Thank you!

@Sean-Der Sean-Der merged commit dbf2254 into pion:master Feb 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants