-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deletion of existing sample_builder implementation codes #2591
Conversation
This commit deletes the existing implementation of sample builder and replaces with raw jech implementation. No further modification has been made in this commit.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2591 +/- ##
===========================================
- Coverage 76.47% 63.33% -13.15%
===========================================
Files 87 63 -24
Lines 9867 3758 -6109
===========================================
- Hits 7546 2380 -5166
+ Misses 1854 1229 -625
+ Partials 467 149 -318
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
You've removed the tests? I don't agree, I think you should leave the tests. That way, when we adjust the tests, we know exactly how much the behaviour of the samplebuilder has changed, and we can decide whether the changes are acceptable or whether we should tweak the new samplebuilder. |
This commit replaces back the inital pion sample builder test with the new implementation. This produces a lot error which we intend to fix by tweaking the implementation against the test.
… into sample_builder_rebuild
@midepeter why is this being committed with you as the author? Since I am the author of the code, I would expect to be credited. Please use the |
@jech oh, I will do that sorry about that. This literally my first time in the open source space I will do that. Apologies |
Hey, I gave this a go and found two issues:
|
Replaced with #2679 |
This commit deletes the existing implementation of sample builder and replaces with raw jech implementation. No further modification has been made in this commit.
Description
Reference issue
Fixes #...