Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max receive buffer size via SettingEngine #2192

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

enobufs
Copy link
Member

@enobufs enobufs commented Apr 23, 2022

Relates to pion/sctp#218

Description

Current pion/sctp's receive buffer size is hardcoded as 1 MiB. This change makes the value configurable from the SettingEngine.

Reference issue

See pion/sctp#218 for more details about the context of this pull-request.

@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #2192 (9f990db) into master (9f990db) will not change coverage.
The diff coverage is n/a.

❗ Current head 9f990db differs from pull request most recent head 1ef4789. Consider uploading reports for the commit 1ef4789 to get more accurate results

@@           Coverage Diff           @@
##           master    #2192   +/-   ##
=======================================
  Coverage   76.84%   76.84%           
=======================================
  Files          87       87           
  Lines        8990     8990           
=======================================
  Hits         6908     6908           
  Misses       1656     1656           
  Partials      426      426           
Flag Coverage Δ
go 78.62% <0.00%> (ø)
wasm 69.94% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f990db...1ef4789. Read the comment docs.

@enobufs enobufs force-pushed the make-sctp-recvbuff-size-configurable branch from bfbf952 to 1ef4789 Compare April 28, 2022 00:08
@enobufs enobufs merged commit dc31439 into master Apr 28, 2022
@enobufs enobufs deleted the make-sctp-recvbuff-size-configurable branch April 28, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants