Skip to content

Commit

Permalink
renamed GetMultiCodecNegotiation() -> MultiCodecNegotiation()
Browse files Browse the repository at this point in the history
  • Loading branch information
itzmanish committed Jan 22, 2025
1 parent 73f3b37 commit 717d618
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 7 deletions.
4 changes: 2 additions & 2 deletions mediaengine.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ func (m *MediaEngine) SetMultiCodecNegotiation(negotiateMultiCodecs bool) {
m.negotiateMultiCodecs = negotiateMultiCodecs
}

// GetMultiCodecNegotiation returns the current state of the negotiation of multiple codecs.
func (m *MediaEngine) GetMultiCodecNegotiation() bool {
// MultiCodecNegotiation returns the current state of the negotiation of multiple codecs.
func (m *MediaEngine) MultiCodecNegotiation() bool {
m.mu.RLock()
defer m.mu.RUnlock()

Expand Down
19 changes: 14 additions & 5 deletions mediaengine_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -926,9 +926,18 @@ a=ssrc:4281768245 msid:6ff05509-be96-4ef1-a74f-425e14720983 16d5d7fe-d076-4718-9

return s
}
mediaEngine := MediaEngine{}
mediaEngine.SetMultiCodecNegotiation(true)
assert.NoError(t, mediaEngine.RegisterDefaultCodecs())
assert.NoError(t, mediaEngine.updateFromRemoteDescription(mustParse(offerSdp)))
assert.Len(t, mediaEngine.negotiatedVideoCodecs, 2)
t.Run("Multi codec negotiation disabled", func(t *testing.T) {
mediaEngine := MediaEngine{}
assert.NoError(t, mediaEngine.RegisterDefaultCodecs())
assert.NoError(t, mediaEngine.updateFromRemoteDescription(mustParse(offerSdp)))
assert.Len(t, mediaEngine.negotiatedVideoCodecs, 1)
})
t.Run("Multi codec negotiation enabled", func(t *testing.T) {
mediaEngine := MediaEngine{}
mediaEngine.SetMultiCodecNegotiation(true)
assert.True(t, mediaEngine.MultiCodecNegotiation())
assert.NoError(t, mediaEngine.RegisterDefaultCodecs())
assert.NoError(t, mediaEngine.updateFromRemoteDescription(mustParse(offerSdp)))
assert.Len(t, mediaEngine.negotiatedVideoCodecs, 2)
})
}

0 comments on commit 717d618

Please sign in to comment.