SampleBuilder: Deprecate PopWithTimestamp

SampleBuilder.PopWithTimestamp() will be removed in v4. Use Sample.PacketTimestamp field instead.
pion · Mar 14, 2024 · 39919d7 · 39919d7
1 parent 0b447fd
commit 39919d7
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/pkg/media/samplebuilder/samplebuilder.go b/pkg/media/samplebuilder/samplebuilder.go
@@ -305,6 +305,8 @@ func (s *SampleBuilder) Pop() *media.Sample {
 // PopWithTimestamp compiles pushed RTP packets into media samples and then
 // returns the next valid sample with its associated RTP timestamp (or nil, 0 if
 // no sample is compiled).
+//
+// Deprecated: PopWithTimestamp will be removed in v4. Use Sample.PacketTimestamp field instead.
 func (s *SampleBuilder) PopWithTimestamp() (*media.Sample, uint32) {
 	sample := s.Pop()
 	if sample == nil {