This repository has been archived by the owner on Dec 27, 2020. It is now read-only.
add example #18
Merged
add example #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at-wat
reviewed
Aug 11, 2020
examples/broadcast/main.go
Outdated
| }() | ||
|
|
||
| // Create a local track, all our SFU clients will be fed via this track | ||
| localTrack, newTrackErr := peerConnection.NewTrack(remoteTrack.PayloadType(), remoteTrack.SSRC(), "video", "pion") |
There was a problem hiding this comment.
(Payload type and SSRC should be automatically set on v3, but new interface is not yet designed)
examples/broadcast/main.go
Outdated
Comment on lines
83
to
91
| i, readErr := remoteTrack.Read(rtpBuf) | ||
| if readErr != nil { | ||
| panic(readErr) | ||
| } | ||
|
|
||
| // ErrClosedPipe means we don't have any subscribers, this is ok if no peers have connected yet | ||
| if _, err = localTrack.Write(rtpBuf[:i]); err != nil && err != io.ErrClosedPipe { | ||
| panic(err) | ||
| } |
Sean-Der
force-pushed
the
example
branch
3 times, most recently
from
f9c4ad1 to
1b91c75
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
just a simple replace now
using //FIXED-TO-V3 to mark
how about merge broadcat+simulcat=mini-sfu in the future
this can show all feature.