You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 27, 2020. It is now read-only.
I'd like to suggest to drop media.Sample from v3 API because of the following reasons:
Transformation rtp.Packet -> Sample is lossy.
As reported in Always set Marker bit to false? rtp#69, roundtrip transformation rtp.Packet -> Sample -> rtp.Packet loose some RTP header flags.
Supporting all of rtp.Packet, media.Sample, binary makes the API complex.
On v2, Track implemented all of Read/ReadSample/ReadRTP and Write/WriteSample/WriteRTP. They are functionally duplicated and will make Track implementation complicated. (A processor of the data should have all of Read/ReadSample/ReadRTP and Write/WriteSample/WriteRTP, and should support all input/output combinations.)
https://github.com/pion/webrtc/wiki/PlanningV3#api-should-deal-in-timeduration-and-abstract-away-samplerate
media.Sample
is confusing. Users shouldn't have to understand the sample-rates of Video vs Audio.The text was updated successfully, but these errors were encountered: