Increment missing indications from SACK #353
Conversation
cnderrauber
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #353 +/- ##
==========================================
+ Coverage 81.43% 81.61% +0.17%
==========================================
Files 51 51
Lines 4337 4341 +4
==========================================
+ Hits 3532 3543 +11
+ Misses 660 655 -5
+ Partials 145 143 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
cnderrauber
force-pushed
the
fastrecover_missing
branch
from
2381c39 to
775266c
Compare
| @@ -1855,7 +1858,7 @@ func (a *Association) handleSack(d *chunkSelectiveAck) error { | |||
| a.setRWND(d.advertisedReceiverWindowCredit - bytesOutstanding) | |||
| } | |||
|
|
|||
| err = a.processFastRetransmission(d.cumulativeTSNAck, htna, cumTSNAckPointAdvanced) | |||
| err = a.processFastRetransmission(d.cumulativeTSNAck, d.gapAckBlocks, htna, cumTSNAckPointAdvanced) | |||
There was a problem hiding this comment.
Don't know the protocol, but just reading this, can this just pass in the end of the last entry? Any reason for passing in the slice?
There was a problem hiding this comment.
Guess, you will have to do the check for length here rather than inside the function. Maybe, six of one and half-a-dozen of other case?
There was a problem hiding this comment.
No difference but I prefer to put the code and comment together to understand all TSNs reported missing from the SACK (gapAckBlocks)
cnderrauber
force-pushed
the
fastrecover_missing
branch
from
775266c to
5f604a4
Compare
|
Mind adding a test @cnderrauber! It’s been a while going to re-read this section |
Increment missing indication for reported missing chunks instead of all inflight chunks.
cnderrauber
force-pushed
the
fastrecover_missing
branch
from
f1eab69 to
d3e02e2
Compare
According to the RFC4960 , the missing indications should be incremented for missing chunks in the SACK.