Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SCTP chunk validation #339

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Conversation

sirzooro
Copy link
Contributor

@sirzooro sirzooro commented Jul 6, 2024

Some chunks were not validated properly what could cause crash.

Some chunks were not validated properly what could cause crash.
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.48%. Comparing base (e23ff7a) to head (01e2c6b).

Files Patch % Lines
error_cause_header.go 0.00% 1 Missing and 1 partial ⚠️
param_requested_hmac_algorithm.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   81.64%   81.48%   -0.16%     
==========================================
  Files          51       51              
  Lines        3323     3327       +4     
==========================================
- Hits         2713     2711       -2     
- Misses        468      471       +3     
- Partials      142      145       +3     
Flag Coverage Δ
go 81.48% <20.00%> (-0.16%) ⬇️
wasm 67.59% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sirzooro sirzooro requested review from paulwe, edaniels and boks1971 July 6, 2024 10:05
Copy link

@boks1971 boks1971 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boks1971 boks1971 requested a review from cnderrauber July 6, 2024 12:03
@sirzooro sirzooro merged commit 553d34c into pion:master Jul 6, 2024
11 of 12 checks passed
@sirzooro sirzooro deleted the fix_chunk_validation branch July 6, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants