Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Associations to be named #307

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Conversation

edaniels
Copy link
Member

@edaniels edaniels commented Feb 28, 2024

Description

This is nice when logs get verbose and you don't want to remember pointer values in your head :)

@edaniels edaniels requested a review from tuexen February 28, 2024 15:14
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (1e43ebf) to head (6e0f6e1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   80.92%   80.96%   +0.03%     
==========================================
  Files          49       49              
  Lines        4167     4165       -2     
==========================================
  Hits         3372     3372              
+ Misses        651      650       -1     
+ Partials      144      143       -1     
Flag Coverage Δ
go 80.96% <100.00%> (+0.03%) ⬆️
wasm 67.29% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels edaniels requested a review from daonb March 3, 2024 13:52
@edaniels edaniels merged commit 3f9fba4 into pion:master Mar 4, 2024
13 checks passed
@edaniels edaniels deleted the named_assoc branch March 4, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants