Support Unknown Parameters in INIT Chunk #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #298 +/- ##
===========================================
- Coverage 80.48% 67.30% -13.18%
===========================================
Files 48 48
Lines 4053 4056 +3
===========================================
- Hits 3262 2730 -532
- Misses 648 1172 +524
- Partials 143 154 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
If someone has the availability mind looking at this? Soon Chrome is going to roll out with this new param (that we don't support yet) Pion is going to fail to negotiate SCTP then. I want to get this out so we don't see DataChannels failing. |
|
Test failure is ok/expected. We are breaking public API by not having unmarshal errors anymore |
edaniels
approved these changes
Feb 8, 2024
Start to implement section-3.2.1 and respect chunks with a action of Skip. We don't properly report the values back yet. Relates to #2618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start to implement section-3.2.1 and respect chunks with a action of Skip. We don't properly report the values back yet.