Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VLA support - an RTP header extension parser/builder #245

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

enobufs
Copy link
Member

@enobufs enobufs commented Jan 7, 2024

Introducing an unmarshaler/marshaler for VLA (Video Layers Allocation), an RTP header extension. This extension is for a video sender to provide information about the target bitrate, resolution and frame rate of each scalability layer in order to aid a selective forwarding middlebox to decide which layer to relay.

NOTE: This change only adds the VLA parser/builder to this module (expected minor change), will not introduce any behavioral change to the existing code.

@enobufs enobufs requested a review from Sean-Der January 7, 2024 20:30
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (314bd8e) 87.50% compared to head (eef54d7) 87.41%.

Files Patch % Lines
vlaextension.go 86.46% 25 Missing and 6 partials ⚠️
codecs/av1/obu/leb128.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   87.50%   87.41%   -0.10%     
==========================================
  Files          20       21       +1     
  Lines        1873     2113     +240     
==========================================
+ Hits         1639     1847     +208     
- Misses        204      230      +26     
- Partials       30       36       +6     
Flag Coverage Δ
go 87.41% <86.66%> (-0.10%) ⬇️
wasm 86.89% <86.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enobufs enobufs changed the title Add VLA extension header parser/builder Add VLA - an RTP header extension parser/builder Jan 7, 2024
@enobufs enobufs changed the title Add VLA - an RTP header extension parser/builder Add VLA support - an RTP header extension parser/builder Jan 7, 2024
@enobufs enobufs force-pushed the add_vla_header_extension branch from c276e74 to e1a4dd1 Compare January 7, 2024 21:33
Added VLA parser, builder and unit tests.
@enobufs enobufs force-pushed the add_vla_header_extension branch from e1a4dd1 to eef54d7 Compare January 7, 2024 21:46
@enobufs enobufs merged commit 78da5a2 into master Jan 28, 2024
14 checks passed
@enobufs enobufs deleted the add_vla_header_extension branch January 28, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant