Combine OneByte and TwoByte extension parsing #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know! |
Sean-Der
force-pushed
the
extension-parsing
branch
from
b27c60d to
1ae5b63
Compare
Reduces duplicated logic and increase coverage. Missing tests for bounds check on Padding and Payload Sizes Co-Authored-By: Juho Nurminen <[email protected]>
Sean-Der
force-pushed
the
extension-parsing
branch
from
854601a to
da6769a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces duplicated logic and increase coverage. Missing tests for bounds check on Padding and Payload Sizes
Co-Authored-By: Juho Nurminen [email protected]