Add H265SafariPayloader #200
Open
+437
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change completes the H265 implementation.
|
Interesting, really weird that Safari decided to create their own payload format. This has some rather odd implications for interoperability, however. Suddenly the payloader needs to know about where the stream is sent :( Is the Safari payloader compatible with ffmpeg RTP and others? If so, maybe it would be better to adopt the Safari format as "standard"... Change looks good to me though, thanks for figuring this out :) |
kevmo314
approved these changes
Nov 3, 2022
|
yes, we don't know why safari decided to use their own payload format. i changed the code to use 'copy' instead of 'append' for memory efficiency. @shlompy, thank you as well! |
Sean-Der
force-pushed
the
h265
branch
2 times, most recently
from
265ba8a to
dd05d22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added H265SafariPayloader.
based on AlexxIT/Blog#5
@kevmo314