Include XR.SenderSSRC in its DestinationSSRC #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 76.08% 77.08% +1.00%
==========================================
Files 21 21
Lines 2421 2422 +1
==========================================
+ Hits 1842 1867 +25
+ Misses 484 460 -24
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
boks1971
reviewed
Mar 1, 2024
| @@ -646,7 +646,8 @@ func (x *ExtendedReport) Unmarshal(b []byte) error { | |||
|
|
|||
| // DestinationSSRC returns an array of SSRC values that this packet refers to. | |||
| func (x *ExtendedReport) DestinationSSRC() []uint32 { | |||
| ssrc := make([]uint32, 0) | |||
| ssrc := make([]uint32, 0, len(x.Reports)+1) | |||
| ssrc = append(ssrc, x.SenderSSRC) | |||
There was a problem hiding this comment.
That function name/meaning is specifically for destination. Guess, for XR case, it is okay to include sender also, but wondering if there is a cleaner option.
There was a problem hiding this comment.
It is not a naming issue, the DestinationSSRC used by pion to dispatch rtcp packets, the packet will be dropped if it doesn't include the SenderSSRC and report block doesn't contain a ssrc field.
Include XR.SenderSSRC in its DestinationSSRC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include XR.SenderSSRC in its DestinationSSRC
Description
Reference issue
Fixes #...