Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky PION_LOG_*, more tests #117

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Fix flaky PION_LOG_*, more tests #117

merged 1 commit into from
Jan 10, 2025

Conversation

joeturki
Copy link
Member

@joeturki joeturki commented Jan 9, 2025

Description

I was tracking an issue with video feedback when I noticed the logs were flaky. Initially, I thought it was a bug, but I later discovered that PION_LOG_*=all is unreliable due to how the range map is ordered.

Added tests to cover everything.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (8466bde) to head (1e7ee6f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #117       +/-   ##
===========================================
+ Coverage   55.71%   97.87%   +42.15%     
===========================================
  Files           2        2               
  Lines         140      141        +1     
===========================================
+ Hits           78      138       +60     
+ Misses         60        2       -58     
+ Partials        2        1        -1     
Flag Coverage Δ
go 97.87% <100.00%> (+42.15%) ⬆️
wasm 97.87% <100.00%> (+42.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joeturki joeturki merged commit 770cd0b into master Jan 10, 2025
13 checks passed
@joeturki joeturki deleted the fix/log-env branch January 10, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants