-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmarshal only actually read bytes #257
base: master
Are you sure you want to change the base?
Conversation
Let me add some tests around this, unless you wish to, and then we can get this merged. |
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
Generated by renovateBot
Update lint scripts and CI configs.
Relates to pion/webrtc#2869
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
==========================================
- Coverage 72.56% 72.48% -0.08%
==========================================
Files 79 79
Lines 3648 3653 +5
==========================================
+ Hits 2647 2648 +1
- Misses 867 869 +2
- Partials 134 136 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ensure reads only use length returned from upstream
3fc6676
to
561796c
Compare
Description
The interceptor tried to unmarshal the whole buffer and didn't respect the actual packet length.
Reference issue
Fixes #255