JitterBuffer Enhancements: Allow setting a minimum length #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 79.79% 79.88% +0.09%
==========================================
Files 70 70
Lines 3791 3818 +27
==========================================
+ Hits 3025 3050 +25
- Misses 633 634 +1
- Partials 133 134 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thatsnotright
force-pushed
the
rob/jitterbuffer_enhancements
branch
6 times, most recently
from
5f53a56 to
20bd731
Compare
thatsnotright
force-pushed
the
rob/jitterbuffer_enhancements
branch
2 times, most recently
from
7579ab8 to
c3a7651
Compare
Add additional helper method to set the minimum packet count before the jitterbuffer will emit packets
thatsnotright
force-pushed
the
rob/jitterbuffer_enhancements
branch
from
c3a7651 to
e36bf9a
Compare
Sean-Der
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the tests (and probably generally to start) we need a way to set when the jitter buffer will begin emitting packets, having met it's minimum threshold.