[FlexFec] Adding FlexFec Flex variant encoder implementation #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
Hey @pougetat it is great to see you :) If you can fix those lint errors I would like to merge this. We can add tests/improve other things later. |
pougetat
changed the title
pougetat
changed the title
Sean-Der
approved these changes
Oct 24, 2023
pougetat
force-pushed
the
pion_flexfec_encode
branch
from
6b5244a to
c74445c
Compare
evgmel
reviewed
Oct 25, 2023
| Marker: false, | ||
| PayloadType: flex.payloadType, | ||
| SequenceNumber: flex.baseSN, | ||
| Timestamp: 54243243, |
There was a problem hiding this comment.
Hi @pougetat. Could you please explain this fixed Timestamp value = 54243243? Is it taken from RFC?
There was a problem hiding this comment.
It's a leftover hardcoded value. I'll get this fixed soon.
There was a problem hiding this comment.
Okay. No problem 👍 Thanks for the explanation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FlexFec is a packet loss recovery technique through which redundant RTP packets are sent and from which missing RTP packets can potentially be reconstructed.
https://datatracker.ietf.org/doc/html/rfc8627
There are multiple variants of FlexFec and I'm adding an implementation of the "Flex" encoder as part of this PR.
The other variants are not included nor is the decoder included which I hope to add in subsequent PRs, this first one is meant to be the start of a series.
This PR also doesn't add the interceptor on top of the encoder.
I'm labeling it as DRAFT for now until I write some proper unit tests to get us some confidence that it works as expected.
Reference issue
Fixes #...