Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send empty NACK packets #211

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Do not send empty NACK packets #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/nack/generator_interceptor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@
}
}

if len(filteredMissing) == 0 {
continue

Check warning on line 195 in pkg/nack/generator_interceptor.go

View check run for this annotation

Codecov / codecov/patch

pkg/nack/generator_interceptor.go#L195 

Added line #L195 was not covered by tests
}

if _, err := rtcpWriter.Write([]rtcp.Packet{nack}, interceptor.Attributes{}); err != nil {
n.log.Warnf("failed sending nack: %+v", err)
}
Expand Down
Loading