support custom streams filter in nack interceptor

pkg/nack/generator_interceptor.go

@@ -21,6 +21,7 @@ type GeneratorInterceptorFactory struct {
 // NewInterceptor constructs a new ReceiverInterceptor
 func (g *GeneratorInterceptorFactory) NewInterceptor(_ string) (interceptor.Interceptor, error) {
 	i := &GeneratorInterceptor{
+		streamsFilter:     streamSupportNack,
 		size:              512,
 		skipLastN:         0,
 		maxNacksPerPacket: 0,
@@ -47,6 +48,7 @@ func (g *GeneratorInterceptorFactory) NewInterceptor(_ string) (interceptor.Inte
 // GeneratorInterceptor interceptor generates nack feedback messages.
 type GeneratorInterceptor struct {
 	interceptor.NoOp
+	streamsFilter     func(info *interceptor.StreamInfo) bool
 	size              uint16
 	skipLastN         uint16
 	maxNacksPerPacket uint16
@@ -86,7 +88,7 @@ func (n *GeneratorInterceptor) BindRTCPWriter(writer interceptor.RTCPWriter) int
 // BindRemoteStream lets you modify any incoming RTP packets. It is called once for per RemoteStream. The returned method
 // will be called once per rtp packet.
 func (n *GeneratorInterceptor) BindRemoteStream(info *interceptor.StreamInfo, reader interceptor.RTPReader) interceptor.RTPReader {
-	if !streamSupportNack(info) {
+	if !n.streamsFilter(info) {
 		return reader
 	}
 

pkg/nack/generator_option.go

@@ -6,6 +6,7 @@ package nack
 import (
 	"time"
 
+	"github.com/pion/interceptor"
 	"github.com/pion/logging"
 )
 
@@ -54,3 +55,11 @@ func GeneratorInterval(interval time.Duration) GeneratorOption {
 		return nil
 	}
 }
+
+// GeneratorStreamsFilter sets filter for remote streams
+func GeneratorStreamsFilter(filter func(info *interceptor.StreamInfo) bool) GeneratorOption {
+	return func(r *GeneratorInterceptor) error {
+		r.streamsFilter = filter
+		return nil
+	}
+}

pkg/nack/responder_interceptor.go

@@ -24,9 +24,10 @@ type packetFactory interface {
 // NewInterceptor constructs a new ResponderInterceptor
 func (r *ResponderInterceptorFactory) NewInterceptor(_ string) (interceptor.Interceptor, error) {
 	i := &ResponderInterceptor{
-		size:    1024,
-		log:     logging.NewDefaultLoggerFactory().NewLogger("nack_responder"),
-		streams: map[uint32]*localStream{},
+		streamsFilter: streamSupportNack,
+		size:          1024,
+		log:           logging.NewDefaultLoggerFactory().NewLogger("nack_responder"),
+		streams:       map[uint32]*localStream{},
 	}
 
 	for _, opt := range r.opts {
@@ -49,6 +50,7 @@ func (r *ResponderInterceptorFactory) NewInterceptor(_ string) (interceptor.Inte
 // ResponderInterceptor responds to nack feedback messages
 type ResponderInterceptor struct {
 	interceptor.NoOp
+	streamsFilter func(info *interceptor.StreamInfo) bool
 	size          uint16
 	log           logging.LeveledLogger
 	packetFactory packetFactory
@@ -99,7 +101,7 @@ func (n *ResponderInterceptor) BindRTCPReader(reader interceptor.RTCPReader) int
 // BindLocalStream lets you modify any outgoing RTP packets. It is called once for per LocalStream. The returned method
 // will be called once per rtp packet.
 func (n *ResponderInterceptor) BindLocalStream(info *interceptor.StreamInfo, writer interceptor.RTPWriter) interceptor.RTPWriter {
-	if !streamSupportNack(info) {
+	if !n.streamsFilter(info) {
 		return writer
 	}
 

pkg/nack/responder_option.go

@@ -3,7 +3,10 @@
 
 package nack
 
-import "github.com/pion/logging"
+import (
+	"github.com/pion/interceptor"
+	"github.com/pion/logging"
+)
 
 // ResponderOption can be used to configure ResponderInterceptor
 type ResponderOption func(s *ResponderInterceptor) error
@@ -33,3 +36,11 @@ func DisableCopy() ResponderOption {
 		return nil
 	}
 }
+
+// GeneratorStreamsFilter sets filter for remote streams
+func ResponderStreamsFilter(filter func(info *interceptor.StreamInfo) bool) ResponderOption {
+	return func(r *ResponderInterceptor) error {
+		r.streamsFilter = filter
+		return nil
+	}
+}