Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDPMuxSink for UDPMux allows to inspect packets before being dropped #746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

astroza
Copy link

@astroza astroza commented Nov 26, 2024

Description

This is one of the features that helped us to build a distributed version of Pion.

Inspecting UDPMux discarded packets makes it possible to evaluate and restore a PeerConnection if needed

Copy link

@nils-ohlmeier nils-ohlmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
But someone else should probably review this as well.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.50%. Comparing base (35bb3fb) to head (589aef2).

Files with missing lines Patch % Lines
udp_mux.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
- Coverage   78.69%   78.50%   -0.20%     
==========================================
  Files          41       41              
  Lines        4769     4773       +4     
==========================================
- Hits         3753     3747       -6     
- Misses        783      790       +7     
- Partials      233      236       +3     
Flag Coverage Δ
go 78.50% <25.00%> (-0.20%) ⬇️
wasm 22.45% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der
Copy link
Member

@nils-ohlmeier You can merge anything without me! As long as it passes the tests I don't care. Nothing worse then waiting on a slow maintainer :)

@astorza that's really cool you were able to build a distributed version! Would you mind writing a test for this? Just assert that if set it really does get fired.

thank you so much for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants