Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint, more linters #235

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Upgrade golangci-lint, more linters #235

merged 1 commit into from
Jan 24, 2025

Conversation

JoeTurki
Copy link
Member

Description

Introduces new linters, upgrade golangci-lint to version (v1.63.4)

Reference issue

pion/.goassets#220

Introduces new linters, upgrade golangci-lint to version (v1.63.4)
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.18%. Comparing base (687754f) to head (8a83b3c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
datachannel.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   65.67%   66.18%   +0.50%     
==========================================
  Files           4        4              
  Lines         335      343       +8     
==========================================
+ Hits          220      227       +7     
- Misses         90       91       +1     
  Partials       25       25              
Flag Coverage Δ
go 66.18% <88.88%> (+0.50%) ⬆️
wasm 66.18% <88.88%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoeTurki JoeTurki merged commit 8a83b3c into master Jan 24, 2025
15 checks passed
@JoeTurki JoeTurki deleted the impr/lint branch January 24, 2025 02:00
@JoeTurki JoeTurki mentioned this pull request Jan 24, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant