Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test codecov #126

Closed
wants to merge 1 commit into from
Closed

Test codecov #126

wants to merge 1 commit into from

Conversation

Sean-Der
Copy link
Member

@Sean-Der Sean-Der commented Apr 8, 2024

Description

Reference issue

Fixes #...

@at-wat
Copy link
Member

at-wat commented Apr 9, 2024

I'm not very sure why CODECOV_TOKEN is changed from secret to plain variable.

https://github.com/codecov/codecov-action?tab=readme-ov-file#breaking-changes says

PRs made from forks to the upstream public repos will support tokenless (e.g. contributors to OS projects do not need the upstream repo's Codecov token)

@Sean-Der
Copy link
Member Author

Sean-Der commented Apr 9, 2024

@at-wat I couldn’t get it to work, it would error that token wasn’t provided.

Do we need different jobs for PR and push to master maybe?

@at-wat
Copy link
Member

at-wat commented Apr 9, 2024

@Sean-Der I confirmed that the upload just works without CODECOV_TOKEN secret for forked PR.
Using https://github.com/pion/.goassets/tree/codecov-token-test this branch reverting recent commits.
https://github.com/pion/ci-sandbox/actions/runs/8609041154/job/23592380300

info - 2024-04-09 01:42:58,540 -- The PR is happening in a forked repo. Using tokenless upload.
info - 2024-04-09 01:43:02,194 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/pion/ci-sandbox/commit/42d0041bd6509a619f233f68c5793404e01c9860
info - 2024-04-09 01:43:02,374 -- Process Upload complete

@Sean-Der
Copy link
Member Author

Sean-Der commented Apr 9, 2024

Thank you @at-wat ! Sorry I didn’t do this right, keep getting pulled away

@Sean-Der Sean-Der closed this Apr 9, 2024
@Sean-Der Sean-Der deleted the codecov-test branch April 9, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants