Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: github minor fixes #1516

Merged
merged 2 commits into from
Nov 15, 2024
Merged

fix: github minor fixes #1516

merged 2 commits into from
Nov 15, 2024

Conversation

zhangvi7
Copy link
Contributor

@zhangvi7 zhangvi7 commented Nov 15, 2024 •
edited
Loading

  • Small fixes:
    • Fix compare/restore: edge case when query cell title is empty string
    • Update documentation detail
    • Update unit test
    • Add missing github package by default as they are used in datadoc_collab.py, for users that are missing it in local.txt (already included in prod image from extra.txt)

@zhangvi7 zhangvi7 merged commit c0ddbfc into pinterest:master Nov 15, 2024
4 checks passed
@zhangvi7 zhangvi7 deleted the rongzhang/fix branch November 15, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jczhong84 jczhong84 jczhong84 approved these changes

@kgopal492 kgopal492 Awaiting requested review from kgopal492

@czgu czgu Awaiting requested review from czgu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangvi7 @jczhong84