feat: add sql completions powered by LLM #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangvi7
reviewed
Nov 14, 2024
Comment on lines
7
to
12
| /** | ||
| * Remove overlapping part with prefix from completion. | ||
| * | ||
| * e.g. removeOverlapPrefix('sel', 'elect *') => 'ect *' | ||
| */ | ||
| const removeOverlapPrefix = (completion: string, prefix: string) => { |
There was a problem hiding this comment.
just curious why is this needed?
There was a problem hiding this comment.
It is a hack workaround. found sometimes it will have overlap with the prefix. I'll add some comments there.
zhangvi7
reviewed
Nov 14, 2024
yes, it supports multiple lines. |
czgu
reviewed
Nov 15, 2024
querybook/webapp/hooks/queryEditor/extensions/useSqlCompleteExtension.ts
Outdated
Show resolved
Hide resolved
czgu
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding another AI assistant feature, SQL Complete, to help query authoring like the Github Copilot
Currently we're using this codemirror extension, we can reimplement it to meet our additional requrements in the future if needed.
The prompt and context still needs to be tuned for better quality.
By default it is disabled, user can enable it in the user settings.
