Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add any links associated with a table to querybook descriptions #1450

Merged
merged 15 commits into from
May 15, 2024

Conversation

zhangvi7
Copy link
Contributor

Description

  • Tables from metatore maybe have links associated to table descriptions
  • Exposing any links that are attached to tables in Querybook
  • Adding table_links column to the data_table_information table and load it from metastore.

Test Plan

image

@zhangvi7 zhangvi7 requested review from czgu, jczhong84 and kgopal492 May 13, 2024 20:36
@zhangvi7 zhangvi7 self-assigned this May 13, 2024
querybook/server/const/metastore.py Outdated Show resolved Hide resolved
querybook/webapp/const/metastore.ts Outdated Show resolved Hide resolved
@zhangvi7
Copy link
Contributor Author

  • fixed lint
  • addressed comments

@zhangvi7 zhangvi7 merged commit d81d582 into pinterest:master May 15, 2024
4 checks passed
@zhangvi7 zhangvi7 deleted the pincat branch May 15, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants