feat: update column stats ui, add sort by usage to columns #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kgopal492
commented
Dec 19, 2023
kgopal492
commented
- Update column stats UI to show table column stats as tags (rather than additional rows)
- Add ability to sort columns by usage
- Query all table column details from table column page to be able to sort columns by usage
czgu
reviewed
Dec 19, 2023
querybook/webapp/components/DataTableStats/DataTableColumnStats.tsx
Outdated
Show resolved
Hide resolved
| const [orderColumnsBy, setOrdeColumnsBy] = React.useState(true); | ||
| const [orderBoardBy, setOrderBoardBy] = React.useState(false); | ||
| const [orderColumnsBy, setOrderColumnsBy] = | ||
| React.useState<ColumnOrderBy>('usage'); |
There was a problem hiding this comment.
if there is no usage, what would happen?
There was a problem hiding this comment.
This 'usage' string just corresponds to the column order by type (so shouldn't use the constant here). If there's no usage, they're all treated as 0 usage. But I updated it so that you can't see the sort by usage option if there are no usages available for any of the columns so it isn't confusing to users.
querybook/webapp/components/DataTableViewColumn/DataTableViewColumn.tsx
Outdated
Show resolved
Hide resolved
czgu
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.