Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: website and docs query_engines links #1367

Closed
wants to merge 1 commit into from

Conversation

alexgann
Copy link

@alexgann alexgann commented Nov 9, 2023

Docs were re-organized to splits connect_to_query_engines.md into connect_to_a_query_engine.md and query_engines.md. Links were not fully updated to align. This quick PR fixes those links as initially reported in #1365

@alexgann alexgann changed the title Fixes query_engines links fix: website and docs query_engines links Nov 9, 2023
Copy link
Collaborator

@czgu czgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@alexgann
Copy link
Author

Of course, @czgu !

Might I ask you to take a look at #1366 - I have the code written for it but was trying to follow the process by describing/demoing the feature first before going too far 😅 - if it's better to get the Draft PR submitted just let me know - pretty straightforward feature that's very helpful for our company's use case.

@jczhong84
Copy link
Collaborator

@czgu I remember you had a PR to use mdx, is this PR still valid?

@alexgann
Copy link
Author

alexgann commented Feb 25, 2024

Looks like @czgu did - still curious on #1366

Thanks!

@alexgann alexgann closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants