Dynamic AMI selection: fix architecture filter #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoasr
changed the title
| @@ -98,7 +97,7 @@ public List<Ami> getAmiList(Map<String, String> filter) { | |||
| DescribeImagesResponse resp = ec2Client.describeImages(builder.build()); | |||
| if (resp.hasImages() && !resp.images().isEmpty()) { | |||
| // The limitation of images newer than 180 days is temporarily suspended | |||
| //ZonedDateTime cutDate = ZonedDateTime.now().minusDays(180); | |||
| // ZonedDateTime cutDate = ZonedDateTime.now().minusDays(180); | |||
There was a problem hiding this comment.
Does that mean we are including all the images now? What is the rationale behind 180 days?
If we want to add a threshold like that I would suggest making it a configuration so it can be set as needed without having to change code.
vahidhashemian
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes architecture filter in the dynamic AMI selection.
Test Plan