Implement ClusterRecoveryAction #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahidhashemian
requested changes
Dec 8, 2023
orion-server/src/main/java/com/pinterest/orion/core/actions/kafka/BrokerRecoveryAction.java
Outdated
Show resolved
Hide resolved
orion-server/src/main/java/com/pinterest/orion/core/actions/kafka/BrokerRecoveryAction.java
Outdated
Show resolved
Hide resolved
orion-server/src/main/java/com/pinterest/orion/core/actions/kafka/ClusterRecoveryAction.java
Outdated
Show resolved
Hide resolved
orion-server/src/main/java/com/pinterest/orion/core/actions/kafka/ClusterRecoveryAction.java
Outdated
Show resolved
Hide resolved
orion-server/src/main/java/com/pinterest/orion/core/actions/kafka/ClusterRecoveryAction.java
Outdated
Show resolved
Hide resolved
orion-server/src/main/java/com/pinterest/orion/core/actions/kafka/ClusterRecoveryAction.java
Outdated
Show resolved
Hide resolved
orion-server/src/main/java/com/pinterest/orion/core/actions/kafka/ClusterRecoveryAction.java
Outdated
Show resolved
Hide resolved
orion-server/src/main/java/com/pinterest/orion/core/actions/kafka/ClusterRecoveryAction.java
Show resolved
Hide resolved
orion-server/src/main/java/com/pinterest/orion/core/actions/kafka/ClusterRecoveryAction.java
Outdated
Show resolved
Hide resolved
| @@ -54,7 +52,7 @@ public class BrokerHealingOperator extends KafkaOperator { | |||
| private long maxNumStaleIntervals = 2; // default 2 times | |||
| private double unhealthyBrokerURPRatioThreshold = 0; // default no URPs allowed | |||
| private int unhealthyAlertFailThreshold = 3; | |||
There was a problem hiding this comment.
Was this not converted to a config?
There was a problem hiding this comment.
These configs are not part of my change. They are the thresholds for alerting.
They are already configurable. You can check line 46-50 and initialize method.
vahidhashemian
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ClusterRecoveryAction: Orion can automatically recover more than one brokers now.
Broker issue can be detected by BrokerHealingOperator. Before this change, if one broker has outage, BrokerHealingOperator will trigger one BrokerRecoveryAction to recovery it. If more than one brokers have issues, BrokerHealingOperator just throws errors and does nothing.
This PR adds a layer ClusterRecoveryAction between BrokerHealingOperator and BrokerRecoveryAction. When BrokerHealingOperator detects one or more brokers with issues, it creates and dispatches a ClusterRecoveryAction to take care of it. ClusterRecoveryAction can decide whether to create multiple BrokerRecoveryActions to fix broker issues based on its own logic.
To avoid one broker being fixed multiple time, the PR introduces a method called removeRecoveringNodesFromCandidates. This Set based lock can make sure in one big time frame, one broker only be healed once.