lightning: set block size for pebble SSTWriter

[joechenrh]

What problem does this PR solve?

Issue Number: close #59014

Problem Summary:

For local sort using pebbles, it seems like the default block size (16K) is not set when writing SST files.

tidb/pkg/lightning/config/config.go

Line 99 in 36e8e34

DefaultBlockSize = 16 * units.KiB

What changed and how does it work?

Set BlockSize to rc.cfg.TikvImporter.BlockSize.

Test was done on my local machine, which using lightning to import a single csv with 2 million rows and 250 columns.

In order to make a relatively fair comparison, I cleared the data and restart the cluster using tiup before each test.

Before:

After:

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.6790%. Comparing base (36e8e34) to head (a891740).
Report is 2 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #59010        +/-   ##
================================================
+ Coverage   73.0285%   73.6790%   +0.6505%     
================================================
  Files          1684       1714        +30     
  Lines        465663     473741      +8078     
================================================
+ Hits         340067     349048      +8981     
+ Misses       104691     103071      -1620     
- Partials      20905      21622       +717     

Flag	Coverage Δ
integration	45.6021% <100.0000%> (?)
unit	72.2119% <100.0000%> (+<0.0001%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	45.2406% <ø> (+0.0086%)	⬆️

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benjamin2037 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS
• lightning/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment