Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, session: store utf8 string in sessionctx #57645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joechenrh
Copy link
Contributor

@joechenrh joechenrh commented Nov 23, 2024

What problem does this PR solve?

Issue Number: close #57646

Problem Summary:

TiCDC relies on DDL Statements from mysql.tidb_ddl_history table to do replication in downstream database, and these DDL statements are obtained through the OriginText() function.

se.SetValue(sessionctx.QueryString, s.OriginText())

// OriginText returns original statement as a string.
func (a *ExecStmt) OriginText() string {

Before PR #57393, the OriginText mistakenly return UTF-8 encoded queries. However, after this PR, this function returns the original queries, which may lead to different results in the downstream.

For example, in the CDC CI, DDLs use GBK encoding. Therefore, you may see the following results in the CI error logs:

An error occured while initializing diff: from upstream: please make sure the filter is correct.: the target has no table to be compared. source-table is ``test`.`表2``, please check log info in /tmp/tidb_cdc_test/kafka_simple_basic/output/sync_diff.log for full details

An error occured while initializing diff: from upstream: please make sure the filter is correct.: the source has no table to be compared. target-table is ``test`.`��2``, please check log info in /tmp/tidb_cdc_test/kafka_simple_basic/output/sync_diff.log for full details

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Nov 23, 2024
Copy link

ti-chi-bot bot commented Nov 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhangjinpeng87 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 23, 2024
Copy link

tiprow bot commented Nov 23, 2024

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4166%. Comparing base (6e22b8c) to head (dbcb4ea).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57645        +/-   ##
================================================
+ Coverage   72.7907%   73.4166%   +0.6259%     
================================================
  Files          1676       1676                
  Lines        463750     463791        +41     
================================================
+ Hits         337567     340500      +2933     
+ Misses       105323     102532      -2791     
+ Partials      20860      20759       -101     
Flag Coverage Δ
integration 43.4457% <60.0000%> (?)
unit 72.2301% <100.0000%> (+0.0414%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.4529% <ø> (+0.0210%) ⬆️
---- 🚨 Try these New Features:

@joechenrh
Copy link
Contributor Author

/cc @lcwangchao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiDCD CI failed after PR 57393
1 participant