executor, session: store utf8 string in sessionctx
#57645
+19
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #57646
Problem Summary:
TiCDC relies on DDL Statements from
mysql.tidb_ddl_history
table to do replication in downstream database, and these DDL statements are obtained through theOriginText()
function.tidb/pkg/session/session.go
Line 2265 in 6e22b8c
tidb/pkg/executor/adapter.go
Lines 379 to 380 in 6e22b8c
Before PR #57393, the
OriginText
mistakenly return UTF-8 encoded queries. However, after this PR, this function returns the original queries, which may lead to different results in the downstream.For example, in the CDC CI, DDLs use GBK encoding. Therefore, you may see the following results in the CI error logs:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.