-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
partition: set AddRecordOpt.isUpdate = true
when update partition records (#57590)
#57622
base: release-8.5
Are you sure you want to change the base?
partition: set AddRecordOpt.isUpdate = true
when update partition records (#57590)
#57622
Conversation
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Defined2014 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57622 +/- ##
================================================
Coverage ? 56.8360%
================================================
Files ? 1770
Lines ? 626453
Branches ? 0
================================================
Hits ? 356051
Misses ? 246334
Partials ? 24068
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #57590
What problem does this PR solve?
Issue Number: close #57588
Problem Summary:
Didn't set
isUpdate = true
before, so it will use the last value in datum as_tidb_rowid
which caused primary key duplicate.If we don't do this during add columns,
len(r) == len(cols)
always equal to true, so it's safe.What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.