-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add azure disk modifier #5958
base: master
Are you sure you want to change the base?
add azure disk modifier #5958
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c74cf4f
to
b58b0fa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5958 +/- ##
==========================================
- Coverage 57.19% 56.98% -0.21%
==========================================
Files 259 260 +1
Lines 33233 45024 +11791
==========================================
+ Hits 19008 25658 +6650
- Misses 12291 17382 +5091
- Partials 1934 1984 +50
|
b58b0fa
to
3cdbac0
Compare
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.9.0 | ||
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.4.0 | ||
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute v1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use a newer version for these modules? then it can reduce the bump in the future.
diskName = parts[len(parts)-1] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to check extract if len(parts) = 9
above, or should we use strings.SplitN
hear?
cred, err := azidentity.NewDefaultAzureCredential(nil) | ||
if err != nil { | ||
return fmt.Errorf("failed to obtain a credential: %v", err) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the behavior without an Azure config? can we do the same check as we did for AWS in dependences.go
?
IsCompleted bool | ||
IsFailed bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these statuses exist for Azure?
What problem does this PR solve?
This PR introduces the Azure Disk Modifier. As of Kubernetes 1.31, the VolumeModifyClass feature remains in beta and is not enabled by default on Azure. As a workaround, we have implemented the Azure Disk Modifier by drawing inspiration from this project's AWS disk modifier implementation. This enhancement allows for disk modification capabilities on Azure, aligning with the existing functionality available for AWS.
This feature will use the kubelet identity of AKS, you should grant kubelet identity permission to modify the disk.
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.
Manual test
Modify the storage request and storage class name, then on Azure portal the disk properties changed as expected.