Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest sync with brave branch chrome version 130 #87

Merged
merged 4,149 commits into from
Nov 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4149 commits
Select commit Hold shift + click to select a range
573cfd2
Fixed flaky sidebar browser test
simonhong Oct 11, 2024
1dc32e1
Merge pull request #25943 from brave/fix-adblock-pref-service-danglin…
bsclifton Oct 11, 2024
ab5fb88
Merge pull request #25947 from brave/fix_flaky_sidebar_browsertest
simonhong Oct 11, 2024
4d0dbc9
1.73.6
brave-builds Oct 11, 2024
0939827
Fixed navigation bar color at private tab (#25923)
AlexeyBarabash Oct 11, 2024
9a24017
Fix placement of inactive tabs setting
emerick Oct 11, 2024
1a82e2f
[DanglinPtr] Fix various unit test violations (#25946)
cdesouza-chromium Oct 11, 2024
b91529f
[DanglingPtr] Add observation to `ViewCounterService` (#25944)
cdesouza-chromium Oct 11, 2024
fda876e
1.73.7
brave-builds Oct 11, 2024
e0be2b7
fix(wallet): Old Activity Route Persisted in Panel
Douglashdaniel Oct 11, 2024
a4ea608
Merge pull request #25952 from brave/cr130-followup-fix-inactive-tabs…
emerick Oct 11, 2024
8b15ada
[Rewards 3.0] Fix Default AC amount display
zenparsing Oct 11, 2024
bd1e757
Merge pull request #25888 from brave/style-wallet-remove-divider-in-p…
Douglashdaniel Oct 11, 2024
f35ee75
Rework our existing group policies and match the style that Chromium …
bsclifton Sep 23, 2024
c2c805b
Update chromium_src/components/policy/resources/policy_templates.py
bsclifton Oct 3, 2024
d466574
Dynamically add the Brave policies to the policy.yaml
bsclifton Oct 4, 2024
791fdd6
Update components/policy/pack_policy_templates.py
bsclifton Oct 4, 2024
066fa3f
Update Brave Rewards description
bsclifton Oct 4, 2024
39bc804
Update Brave Wallet description
bsclifton Oct 4, 2024
7dca001
Update the URL shown in brave://policy to point at our help URL
bsclifton Oct 4, 2024
da43821
FIXUP: None check => assert, some others
bsclifton Oct 11, 2024
bbbccf7
Update Tor Disabled description
bsclifton Oct 11, 2024
ee5c512
Merge pull request #25710 from brave/bsc-brave-specific-templates
bsclifton Oct 11, 2024
7401b34
Merge pull request #25955 from brave/ksmith-rewards-3-ac-default
zenparsing Oct 11, 2024
27fdd69
AI Chat: display line breaks in human messages (#25825)
petemill Oct 11, 2024
c024139
update adblock-rust to v0.9.2
antonok-edm Oct 13, 2024
0ee8a41
[Toggle]: Fix toggles not toggling
fallaciousreasoning Oct 13, 2024
4a7f810
1.73.8
brave-builds Oct 14, 2024
d78cd08
fix(wallet): Fix tx submission screen gets dismissed automatically af…
nuo-xu Oct 14, 2024
e49d346
Merge pull request #25966 from brave/fix-toggles
bsclifton Oct 14, 2024
6b3a05d
[CodeHealth] Use `string_view` with l10n utils (#25962)
cdesouza-chromium Oct 14, 2024
02fcab6
[CodeHealth][ads] Use `base::ScopedObservation` pt.1 (#25961)
cdesouza-chromium Oct 14, 2024
f6d9165
1.73.9
brave-builds Oct 14, 2024
d2e7bfb
Roll perf profiles update (update-perf-profile-2024-10-13-16-16) (#25…
brave-builds Oct 14, 2024
e53e944
Merge pull request #25953 from brave/fix-wallet-old-activity-route-pe…
Douglashdaniel Oct 14, 2024
ea08eba
1.73.10
brave-builds Oct 14, 2024
b4a1040
Change default font in desktop settings to system fonts (#25937)
aguscruiz Oct 14, 2024
065115c
feat(wallet): add squid to cross-chain swap providers (#25676)
onyb Oct 14, 2024
3b93b5c
1.73.11
brave-builds Oct 15, 2024
699b92b
Use base BrowserTabStripController for pinned tab container, similarl…
Ilie-Lesan Sep 2, 2024
5ebe711
Presubmit formating
Ilie-Lesan Sep 2, 2024
25db86c
Clear group id in-advance when tab is moved to pinned container
simonhong Oct 15, 2024
07178bf
Merge pull request #25983 from brave/llie/when-using-vertical-tabs-pi…
simonhong Oct 15, 2024
b04bb97
Redone SafeBrowsing by using SafeBrowsingApiHandler and SafetyNetClie…
AlexeyBarabash Oct 15, 2024
4443309
Content picker follow up (#25956)
atuchin-m Oct 15, 2024
2dbbbe1
Remove performance settings from basic page
emerick Oct 12, 2024
1bf07c9
Avoid throwing an associated-control exception on settings pages
emerick Oct 12, 2024
a81b2b1
1.73.12
brave-builds Oct 15, 2024
db4bf0b
[ads] Deprecate `ReplaceBraveSchemeWithChromeScheme`
tmancey Oct 14, 2024
97df5d3
[ads] General code health
tmancey Sep 9, 2024
1e5d680
Merge pull request #25977 from brave/issues/41627
tmancey Oct 15, 2024
c920b60
Update titles for server selection page
deeppandya Oct 15, 2024
00ef18e
Leo annual subscription on Android
SergeyZhukovsky Oct 11, 2024
8c0f665
Remove unused profile argument from adaptive captcha methods
emerick Oct 12, 2024
2b86317
Remove unused by_user argument from Close delegate
emerick Oct 12, 2024
e5a63d9
Remove adaptive captcha notification animation
emerick Oct 12, 2024
103bae6
Fix BraveTooltipPopup::Show
emerick Oct 12, 2024
e6c7d49
[CodeHealth][rewards] Use `base::ScopedObservation` pt.2 (#25972)
cdesouza-chromium Oct 15, 2024
3a1188a
Merge pull request #25929 from brave/android_leo_annual
SergeyZhukovsky Oct 15, 2024
4e9c803
1.73.13
brave-builds Oct 15, 2024
15dac4b
Merge pull request #25994 from brave/emerick-fix-adaptive-captcha-tests
emerick Oct 15, 2024
7373fca
Merge pull request #25991 from brave/issues/41634
tmancey Oct 15, 2024
07daa01
fix(wallet): Incorrect Recipient Label on Transaction Confirmed Screen
Douglashdaniel Oct 15, 2024
fa25519
Updated l10n for 1.71.x release. (#25980)
mkarolin Oct 15, 2024
62dc319
Merge pull request #25993 from brave/emerick-hide-chrome-speed-settings
emerick Oct 15, 2024
7a362dd
(Android) Redesign private tab UI (#25850)
simoarpe Oct 15, 2024
a327ced
encapsulate rust json code in cpp (#25975)
bridiver Oct 15, 2024
8365a01
Update hamburge menu for VPN
deeppandya Oct 15, 2024
ab85ec5
[iOS] - Allow user to cancel deleting all history (#25652)
Brandon-T Oct 15, 2024
c839e16
Merge pull request #25995 from brave/server_selection_page_title_change
deeppandya Oct 15, 2024
7faa58f
Merge pull request #26002 from brave/fix-wallet-incorrect-recipient-l…
Douglashdaniel Oct 15, 2024
bf6852c
Merge pull request #26004 from brave/maxk-1.71.x-release-l10n-master
mkarolin Oct 15, 2024
b5fd2a8
[ads] HTTP status code health
tmancey Sep 11, 2024
f5f323b
[ads] Add HTTP status code util
tmancey Sep 16, 2024
4783424
[ads] Add [Notify|On]TabDidLoad
tmancey Sep 16, 2024
b419fe2
[ads] Followup to "Send HTTP response status for landed events as par…
tmancey Sep 16, 2024
59551fb
[ads] Should not `NotifyTabContentDidChange` if tab was restored
tmancey Oct 15, 2024
31d5aeb
[ads] Add ads service waiter for testing
tmancey Oct 11, 2024
d17b06d
Merge pull request #26005 from brave/update_hamburger_menu_vpn
deeppandya Oct 15, 2024
b4153a2
[ads] General code health
tmancey Oct 11, 2024
72980bf
[ads] Ads tab helper browser tests
tmancey Oct 13, 2024
0d79285
upgrade storybook to 8.3.5 (#25794)
petemill Oct 15, 2024
b3602aa
[Brave News]: Don't use TestingProfile in component unittests (#25914)
fallaciousreasoning Oct 15, 2024
cdfe99b
Merge pull request #25523 from brave/issues/40991
tmancey Oct 15, 2024
f1b0dd8
Update URL for inactive tabs appearance
emerick Oct 15, 2024
0ac0246
Update Setting UI for server selection option
deeppandya Oct 15, 2024
c488138
Update rate UI
deeppandya Oct 10, 2024
abdf5da
[ads] Do not discard API calls during ads initialization
aseren Oct 15, 2024
fe56aaf
Changed UTF8String to SysNSStringToUTF8 calls
aseren Oct 15, 2024
c7cec2f
Add `usage-ping.brave.com` to pinned TLS, HSTS and network audit lists
DJAndries Oct 15, 2024
1d93922
Upgrade from Chromium 130.0.6723.44 to Chromium 130.0.6723.58 (#26013)
emerick Oct 15, 2024
98198b3
1.73.14
brave-builds Oct 16, 2024
41a991e
[ads] Add OnceClosureTaskQueue tests
aseren Oct 15, 2024
5c1eb2b
[ads] Fixes intermittent crash during Brave Rewards reset
aseren Sep 5, 2024
9e90f27
Merge pull request #25453 from brave/issues/40864
aseren Oct 16, 2024
f29a8da
Merge pull request #26023 from brave/add-ping-url-to-list
DJAndries Oct 16, 2024
5e19b6a
Adjust create wallet account ui (#25948)
supermassive Oct 16, 2024
9127e9f
Disable TFLITE_USE_STD_ALIGNED_ALLOC on Android (#26006)
darkdh Oct 16, 2024
0fe07f7
1.73.15
brave-builds Oct 16, 2024
2aed6e7
Merge pull request #25998 from brave/issues/41628
aseren Oct 16, 2024
6f264e4
1.73.16
brave-builds Oct 16, 2024
b37cceb
Use the proper index when dragging a tab group
Ilie-Lesan Aug 15, 2024
3c3f49d
Add a test for the scenario when a user drags a tab group out of the …
Ilie-Lesan Sep 30, 2024
1474d64
Revert "Add a test for the scenario when a user drags a tab group out…
Ilie-Lesan Oct 5, 2024
81c1d26
Add a browser test for tab group drag issue
Ilie-Lesan Oct 5, 2024
60990c1
Disabled group detach test on macOS and Linux
simonhong Oct 16, 2024
3518f59
Updated Tor button style. (#25927)
boocmp Oct 16, 2024
f0f0e40
Merge pull request #26017 from brave/cr130-followup-fix-discard-ring-…
emerick Oct 16, 2024
058fd49
1.73.17
brave-builds Oct 16, 2024
a6ac9e7
Improved OnboardingTest
simonhong Oct 16, 2024
571021b
Merge pull request #26030 from brave/improve_on_boarding_tab_helper_test
simonhong Oct 16, 2024
f9c5bad
[ads] Do not show SmartNTTs in legacy browsers
tmancey Oct 15, 2024
8676350
[ads] Do not show SmartNTT for invalid condition matchers
tmancey Oct 15, 2024
810a34f
[ads] Add SmartNTT logging to help diagnose invalid condition matchers
tmancey Oct 15, 2024
79e00bc
Merge pull request #25938 from brave/rate_dialog_update
deeppandya Oct 16, 2024
2724f43
Merge pull request #25160 from Ilie-Lesan/browser-crashed-while-dragg…
bsclifton Oct 16, 2024
bd6d33f
fix(wallet): 0x Recipient Label on Transaction Confirmed Screen
Douglashdaniel Oct 16, 2024
cd0cda9
1.73.18
brave-builds Oct 16, 2024
6cdf99f
Merge pull request #26022 from brave/update_server_selection_settings
deeppandya Oct 16, 2024
a622f9d
Fix dumps without crashing in updater::DoPeriodicTasks (#26037)
mherrmann Oct 16, 2024
ec86a79
(Wallet) Prevent inserting multiple custom networks (#26039)
simoarpe Oct 16, 2024
b871250
Use system_health wpr to rebase profile (#25990)
atuchin-m Oct 16, 2024
48cd87c
Add missing apply patch changes for tflite (#26041)
darkdh Oct 16, 2024
8422696
Migrate occurrences of NOTREACHED_IN_MIGRATION for Rewards
zenparsing Oct 16, 2024
f3277d2
fix(wallet): Missing Activity Button in Android Wallet Nav
Douglashdaniel Oct 16, 2024
af75cf1
[ads] Add additional SmartNTT unit tests
tmancey Oct 15, 2024
946983a
Merge pull request #26046 from brave/ksmith-rewards-notreached
zenparsing Oct 16, 2024
65ef9c7
1.73.19
brave-builds Oct 16, 2024
d67b8d0
Merge pull request #26021 from brave/issues/41648
tmancey Oct 16, 2024
3637776
1.73.20
brave-builds Oct 17, 2024
23033b7
[CodeHealth] Use span of bytes to read arbitrary data (#25978)
cdesouza-chromium Oct 17, 2024
04dfaab
Use spanification to avoid unsafe buffer operations
simonhong Oct 17, 2024
e59212a
[CodeHealth] Enable `-Wunsafe-buffer-usage` across brave (#26027)
cdesouza-chromium Oct 17, 2024
d115392
Merge pull request #26055 from brave/avoid_unsafe_buffer_warning
simonhong Oct 17, 2024
acff99d
Fixed startup failure from VerticalTabStripRegionView width constraint
simonhong Oct 17, 2024
4cea285
Add IPFS Component build flag, some other review suggestions follow u…
vadimstruts Oct 17, 2024
0283c8a
1.73.21
brave-builds Oct 17, 2024
0a86532
[DanglingPtr] Cherry-pick upstream build failure fix (#26052)
cdesouza-chromium Oct 17, 2024
28ee648
Rerun compare-chromium-versions in all PRs after a chromium major ver…
wknapik Oct 17, 2024
0ab1734
Merge pull request #26038 from brave/fix-wallet-0x-recipient-label-on…
Douglashdaniel Oct 17, 2024
2f732c4
Merge pull request #26044 from brave/fix-wallet-missing-activity-butt…
Douglashdaniel Oct 17, 2024
da2cbcf
[iOS] - Fix securing message handlers on iOS-18 (#26014)
Brandon-T Oct 17, 2024
3d20f31
[iOS] - Fix crash in Media permissions prompt (#26000)
Brandon-T Oct 17, 2024
d784f22
[iOS] - Add Free Trial to Leo on iOS (#26001)
Brandon-T Oct 17, 2024
4bf6461
1.73.22
brave-builds Oct 17, 2024
e2413e0
Fix use after fee of active_chat_tab_helper_ raw pointer (#26058)
darkdh Oct 17, 2024
bfeeb4f
[iOS] Ensure bundled favicon initialization happens only once
kylehickinson Oct 17, 2024
cf46f4e
[BYOM] Clear model index on save (#25984)
jonathansampson Oct 17, 2024
7a94ba9
fix(privacy): Fix Shred on app close (#25954)
StephenHeaps Oct 17, 2024
bbda3e7
[BYOM] Introduces support for custom context sizes (#25864)
jonathansampson Oct 17, 2024
c6febdf
[iOS] - Fix VPN subscriptions ignoring empty transactions states (#25…
Brandon-T Oct 17, 2024
264a092
[BYOM] Moves page-content to own entry (#25807)
jonathansampson Oct 17, 2024
9c2189d
Improves teardown to prevent failing test on Win (#25960)
jonathansampson Oct 17, 2024
f0c6454
1.73.23
brave-builds Oct 17, 2024
02d588f
Replace requests to `laptop-updates.brave.com` with requests to `usag…
DJAndries Oct 10, 2024
554aed9
1.73.24
brave-builds Oct 18, 2024
dfc2fba
Add temporary work-around for unsafe buffers
bsclifton Oct 18, 2024
1097433
Merge pull request #26059 from brave/vertical_tab_startup_crash
simonhong Oct 18, 2024
64760cc
Merge pull request #26084 from brave/bsc-fix-unsafe-buffer-windows-test
bsclifton Oct 18, 2024
47c01da
Fixed device duplication when Google Account cookies are deleted (#25…
AlexeyBarabash Oct 18, 2024
cd7c3ed
1.73.25
brave-builds Oct 18, 2024
a9fb670
fix(privacy): Fix shred button visibility (#26049)
StephenHeaps Oct 18, 2024
1162f4c
Merge pull request #26070 from brave/ios-favicon-crash-fix
kylehickinson Oct 18, 2024
2984dc1
[iOS] - Properly handle URL eliding when blobs are given. (#26085)
Brandon-T Oct 18, 2024
d6f8667
[BYOM] Custom System Prompts (#25727)
jonathansampson Oct 18, 2024
3655631
[cr130 follow up][Settings] Restores normal window search engine text.
mkarolin Oct 18, 2024
a0cca7c
1.73.26
brave-builds Oct 18, 2024
eb18803
sec(wallet): show warning for System Program assign instruction (#26088)
onyb Oct 18, 2024
0869c32
1.73.27
brave-builds Oct 18, 2024
96b7cfc
[ads] Followup to "Smart NTT" #41303
aseren Oct 17, 2024
9e61c4d
Merge pull request #25920 from brave/replace-laptop-updates
DJAndries Oct 18, 2024
d7fbae2
Remove laptop-updates from pinned TLS, HSTS and network audit allowlists
DJAndries Oct 18, 2024
2222894
Merge pull request #26098 from brave/maxk-settings-ui-restore-search-…
mkarolin Oct 18, 2024
25ddfaf
Merge pull request #26083 from brave/issues/41695
tmancey Oct 18, 2024
4cb3b0e
Merge pull request #26103 from brave/replace-laptop-updates
DJAndries Oct 18, 2024
a20ec2c
[iOS] - Fix Session Restore URL Display (#26099)
Brandon-T Oct 19, 2024
2f4d949
[ads] Handle search result ad right click
aseren Oct 15, 2024
ec3c91e
Roll perf profiles update (update-perf-profile-2024-10-20-16-16) (#26…
brave-builds Oct 20, 2024
bbb6ebb
Merge pull request #25786 from brave/issues/40785
aseren Oct 20, 2024
d4e838b
1.73.28
brave-builds Oct 20, 2024
5df30a0
1.73.29
brave-builds Oct 21, 2024
38b470f
Enable BraveWalletBitcoinLedger by default (#26060)
supermassive Oct 21, 2024
1773dac
[Android] Add an option Show/Hide Undo bar when tab[s] closed.
jagadeshjai Aug 25, 2024
2b2ed37
[Android] Use reflection to call |showUndoBar| in |UndoBarController|…
jagadeshjai Sep 2, 2024
2e337e7
[Android] Rename "show_undo_on_tab_closed" -> "show_undo_when_tabs_cl…
jagadeshjai Sep 12, 2024
dcce38b
Fixed crash. (#26110)
boocmp Oct 21, 2024
665076f
1.73.30
brave-builds Oct 21, 2024
bc930df
[Rewards 3.0] Fix mojo struct ptr access when querying creator info
zenparsing Oct 21, 2024
a0a87f5
Merge pull request #25964 from brave/adblock-0.9.2
antonok-edm Oct 21, 2024
100331d
[ads] AdsService::Delegate code health
aseren Oct 21, 2024
e7bec70
Include component versions in webcompat reports (#25688)
vadimstruts Oct 21, 2024
e288ba7
Merge pull request #26118 from brave/ksmith-rewards-3-crash-fix
zenparsing Oct 21, 2024
7c69785
1.73.31
brave-builds Oct 21, 2024
0d17590
Merge pull request #25310 from jagadeshjai/feature__toggle_for_show_u…
bsclifton Oct 21, 2024
65e79ab
Bump secp256k1 from 4.0.3 to 4.0.4
dependabot[bot] Oct 21, 2024
c232084
Internationalization Support for Leo (#25931)
bbondy Oct 21, 2024
4558b8a
[ads] General code health
tmancey Oct 17, 2024
01038a1
Fixed crash at TabGroupSyncFeatures.isTabGroupSyncEnabled (#26119)
AlexeyBarabash Oct 21, 2024
678eb40
Merge pull request #26121 from brave/dependabot/npm_and_yarn/secp256k…
diracdeltas Oct 21, 2024
89fe1b1
Merge pull request #26120 from brave/issues/41767
tmancey Oct 21, 2024
e168d77
Migrate hardcoded values into Nala tokens (#26015)
aguscruiz Oct 21, 2024
ed498e3
Removed using SidePanelCoordinator::OnEntryWillDeregister
simonhong Oct 17, 2024
a4d955c
Merge pull request #26117 from brave/issues/41755
aseren Oct 21, 2024
efeda2c
1.73.32
brave-builds Oct 22, 2024
7b7391e
1.73.33
brave-builds Oct 22, 2024
74374a2
Merge pull request #26056 from brave/sidebar_deprecate_OnEntryWillDer…
simonhong Oct 22, 2024
d744024
Add dumps to debug empty shields settings in v8 workers. (#26115)
goodov Oct 22, 2024
ca4c698
Fixed empty channel on release build for Android (#26122)
vadimstruts Oct 22, 2024
ebdbc25
[ubsan] Fix `SplitViewBrowserData` null deref (#26109)
cdesouza-chromium Oct 22, 2024
a9151b2
1.73.34
brave-builds Oct 22, 2024
dc8a84d
Remove override to not misuse ProfileKeyedServiceFactory. (#26089)
goodov Oct 22, 2024
9151b5d
fix(privacy): Crash on launch with Shred and keep private tabs enable…
StephenHeaps Oct 22, 2024
10147fe
1.73.35
brave-builds Oct 22, 2024
1e778bd
1.73.36
brave-builds Oct 22, 2024
15ba9b6
Allow repeated deferral of adaptive captcha
emerick Oct 21, 2024
126b504
Fix interstitial not showing deceptive site warning. Fix URLBar Elidi…
Brandon-T Oct 22, 2024
b3eb4ec
Merge pull request #26127 from brave/emerick-rewards-allow-repeated-a…
emerick Oct 22, 2024
0056fe2
1.73.37
brave-builds Oct 22, 2024
3693cc8
Merge branch 'main' into chrome-130
udaybansal19 Oct 24, 2024
52914a0
Fixed string files
udaybansal19 Oct 24, 2024
c95c2bc
new tab page and logo fixes
udaybansal19 Oct 25, 2024
4059f48
Wallet ui fixes
udaybansal19 Oct 25, 2024
fb36a6a
settings ui fixes
udaybansal19 Oct 26, 2024
591bc64
Fixed ping icons in omnibox and infobar
udaybansal19 Oct 27, 2024
95af513
hid sidebar option in main hamburger menu
udaybansal19 Oct 27, 2024
91d322b
fixed ad blocker
udaybansal19 Oct 27, 2024
39f3dd4
fix context menu and high contrast
udaybansal19 Oct 27, 2024
be3d29e
fixed internal url brave -> ping
udaybansal19 Oct 27, 2024
617788e
Supressed unsafe buffer warning for low_level.cc
udaybansal19 Oct 27, 2024
9cfa294
removed TODOs
udaybansal19 Oct 27, 2024
8f5ac97
hidden leo icons in release build
udaybansal19 Oct 28, 2024
6f6f883
Fixed leo chat settings and omnibaox shortcut
udaybansal19 Oct 28, 2024
51b605b
updated mac config
udaybansal19 Oct 28, 2024
045fa08
ios fixes
udaybansal19 Oct 30, 2024
6f1a6fb
sync icon
udaybansal19 Oct 30, 2024
53d0b2c
sync icons
udaybansal19 Oct 30, 2024
192f9f7
Merge branch 'main' of https://github.com/ping-browser/ping-core into…
Bhavyakala Nov 1, 2024
25d2e49
Synced latest root store
udaybansal19 Nov 1, 2024
2d16abd
Merge branch 'chrome-130' of github.com:ping-browser/ping-core into c…
udaybansal19 Nov 1, 2024
6b06e03
Merge branch 'chrome-130' of https://github.com/ping-browser/ping-cor…
Bhavyakala Nov 2, 2024
609f16a
change azure endpoint
Bhavyakala Nov 2, 2024
d5c9fc0
Merge branch 'chrome-130' of github.com:ping-browser/ping-core into c…
udaybansal19 Nov 2, 2024
10e4ed3
//mojo/public/mojom/
Nikhil7174 Nov 3, 2024
421be2f
Merge branch 'chrome-130' of https://github.com/Ping-browser/ping-cor…
Nikhil7174 Nov 3, 2024
03b874e
android chromium-130 changes
Nikhil7174 Nov 3, 2024
dc28efa
ios internal url fixes
udaybansal19 Nov 4, 2024
9e806c7
android minor changes
Nikhil7174 Nov 4, 2024
e71b990
brave-stats hidden
Nikhil7174 Nov 4, 2024
d3bcbe3
resolved commets
Nikhil7174 Nov 10, 2024
5c7c61e
Merge pull request #86 from ping-browser/nikhil/chrome-130
Nikhil7174 Nov 10, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
17 changes: 16 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,16 @@ module.exports = {
'es6': true,
'jest/globals': true
},
'plugins': ['jest', 'licenses', 'react-hooks'],
'plugins': ['jest', 'licenses', 'no-unsanitized', 'react-hooks'],
'globals': {
'chrome': 'readonly'
},
'parserOptions': {
'project': './tsconfig-lint.json'
},
'rules': {
'no-unsanitized/method': 'error',
'no-unsanitized/property': 'error',
'licenses/header': [
2,
{
Expand Down Expand Up @@ -161,6 +163,19 @@ module.exports = {
'react-hooks/rules-of-hooks': 'error', // Checks rules of Hooks
'react-hooks/exhaustive-deps': 'warn' // Checks effect dependencies
}
},
// opt-out stories for rules of hooks, or we can't use useState in the render functions
// https://github.com/storybookjs/eslint-plugin-storybook/pull/149
// Note: Just using that plugin doesn't help as we opt back in to the rules
// of hooks for wallet.
{
'files': [
'components/**/*.stories.tsx',
'components/**/stories/*.tsx',
],
'rules': {
'react-hooks/rules-of-hooks': 'off', // Don't check hooks
}
}
]
}
19 changes: 19 additions & 0 deletions .git-blame-ignore-revs
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# git hyper-blame master ignore list.
#
# This file contains a list of git hashes of revisions to be ignored by git
# hyper-blame (in depot_tools). These revisions are considered "unimportant" in
# that they are unlikely to be what you are interested in when blaming.
#
# Instructions:
# - Only large (generally automated) reformatting or renaming PRs should be
# added to this list. Do not put things here just because you feel they are
# trivial or unimportant. If in doubt, do not put it on this list.
# - Precede each revision with a comment containing the first line of its log.
# For bulk work over many commits, place all commits in a block with a single
# comment at the top describing the work done in those commits.
# - Only put full 40-character hashes on this list (not short hashes or any
# other revision reference).
# - Append to the bottom of the file (revisions should be in chronological order
# from oldest to newest).
# - Because you must use a hash, you need to append to this list in a follow-up
# PR to the actual reformatting PR that you are trying to ignore.
16 changes: 16 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,21 @@ DEPS @brave/deps-reviewers
script/deps.py @brave/deps-reviewers
package*.json @brave/js-deps-reviewers

# BraveBrowserProcess public interface
browser/brave_browser_process.h @bridiver

# BraveComponent is deprecated
components/brave_component_updater/browser/brave_component.h @bridiver @antonok-edm
components/brave_component_updater/browser/local_data_files_observer.h @bridiver @antonok-edm

# BravePrefServiceBridge is deprecated
browser/android/preferences/brave_pref_service_bridge.cc @bridiver

# sources.gni - see docs/gni_sources.md
**/sources.gni @brave/sources-gni-reviewers
**/*_sources.gni @brave/sources-gni-reviewers
docs/gni_sources.md @brave/sources-gni-reviewers

# Renderer code
**/renderer/**/* @brave/renderer-reviewers

Expand Down Expand Up @@ -74,6 +89,7 @@ brave/components/brave_ads/core/internal/security/**/*.mm @brave/ads-client

# Network
browser/net/ @iefremov
chromium_src/chrome/browser/net/profile_network_context_service.cc @brave/sec-team
chromium_src/net/tools/transport_security_state_generator/input_file_parsers.cc @brave/sec-team

# Tor
Expand Down
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ Resolves
* CI/run-audit-deps (1) - check for known npm/cargo vulnerabilities (audit_deps)
* CI/run-network-audit (1) - run network-audit
* CI/run-upstream-tests - run Chromium unit and browser tests on Linux and Windows (otherwise only on Linux)
* CI/run-linux-arm64, CI/run-macos-arm64, CI/run-windows-arm64, CI/run-windows-x86 - run builds that would otherwise be skipped
* CI/run-linux-arm64, CI/run-macos-x64, CI/run-windows-arm64, CI/run-windows-x86 - run builds that would otherwise be skipped
* CI/skip - do not run CI builds (except noplatform)
* CI/skip-linux-x64, CI/skip-android, CI/skip-macos-x64, CI/skip-ios, CI/skip-windows-x64 - skip CI builds for specific platforms
* CI/skip-linux-x64, CI/skip-android, CI/skip-macos-arm64, CI/skip-ios, CI/skip-windows-x64 - skip CI builds for specific platforms
* CI/skip-upstream-tests - do not run Chromium unit, or browser tests (otherwise only on Linux)
* CI/skip-all-linters - do not run presubmit and lint checks
* CI/storybook-url (1) - deploy storybook and provide a unique URL for each build
Expand Down
68 changes: 0 additions & 68 deletions .github/workflows/codeql-analysis.yml

This file was deleted.

48 changes: 48 additions & 0 deletions .github/workflows/compare-chromium-versions.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
name: Compare Chromium versions

on:
pull_request:
types: [opened, reopened, synchronize]

permissions:
pull-requests: write

jobs:
compare-chromium-versions:
runs-on: ubuntu-latest
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_NUMBER: ${{ github.event.pull_request.number }}
PR_SHA: ${{ github.event.pull_request.head.sha }}
steps:
- name: Check if CI and merge are allowed based on the Chromium version in the target branch
run: |
shopt -s inherit_errexit
set -eEo pipefail

chromium_ver() { curl -fsS "https://raw.githubusercontent.com/${GITHUB_REPOSITORY:?}/${1:?}/package.json"|jq -r .config.projects.chrome.tag; }

pr_ver="$(chromium_ver "${PR_SHA:?}")"
target_ver="$(chromium_ver "${GITHUB_BASE_REF:?}")"

status() { echo "::${1:?}::${2:?}"; echo "$2" >>"${GITHUB_STEP_SUMMARY:?}"; }
label() { gh pr edit "${PR_NUMBER:?}" -R "${GITHUB_REPOSITORY:?}" "--${1:?}-label" chromium-version-mismatch >/dev/null; }
success() { status notice "${1:?}: CI ✅ | Merge ✅"; label remove; }
failure() {
case "${1:?}" in runci) ci=✅; label remove;; *) ci=🚫; label add;; esac
status error "${2:?}: CI $ci | Merge 🚫"
status error "Please rebase."
exit 2
}

echo "::notice::PR branch: ${pr_ver:?}, target branch: ${target_ver:?}"

if [[ "$pr_ver" == "$target_ver" ]]; then
success "Chromium version full match"
elif [[ "$(sort -V <<<"$target_ver"$'\n'"$pr_ver"|tail -n1)" == "$pr_ver" ]]; then
success "Chromium version is newer in the PR"
elif [[ "${pr_ver%%.*}" == "${target_ver%%.*}" ]]; then
success "Chromium major version match"
else
failure blockci "Chromium version mismatch"
fi
47 changes: 47 additions & 0 deletions .github/workflows/rerun-compare-chromium-versions.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: Rerun Compare Chromium versions

on:
pull_request:
branches:
- master
- '[0-9]+.[0-9]+.x'
paths:
- package.json
types:
- closed

jobs:
rerun-compare-chromium-versions:
if: github.event.pull_request.merged == true
runs-on: ubuntu-latest
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_SHA: ${{ github.event.pull_request.head.sha }}
TARGET_SHA: ${{ github.event.pull_request.base.sha }}
steps:
- run: |
shopt -s inherit_errexit
set -eEo pipefail

chromium_ver() { curl -fsS "https://raw.githubusercontent.com/${GITHUB_REPOSITORY:?}/${1:?}/package.json"|jq -r .config.projects.chrome.tag; }

pr_ver="$(chromium_ver "${PR_SHA:?}")"
target_ver="$(chromium_ver "${TARGET_SHA:?}")"

echo "::notice::PR branch: ${pr_ver:?}, target branch: ${target_ver:?}"

if [[ "${pr_ver%%.*}" != "${target_ver%%.*}" ]]; then
while read -r pr_number head_sha; do
run_id="$(gh api "/repos/$GITHUB_REPOSITORY/actions/workflows/compare-chromium-versions.yml/runs?head_sha=${head_sha:?}" -q '.workflow_runs[0].id')"
pr_url="https://github.com/brave/brave-core/pull/${pr_number:?}"
if [[ "$run_id" ]]; then
echo "Rerunning $run_id for $pr_url"
gh -R "$GITHUB_REPOSITORY" run rerun "$run_id"
else
echo "No run found for $pr_url"
fi
sleep 1
done < <(gh -R "$GITHUB_REPOSITORY" pr list --limit 1000 --state open --base "$GITHUB_BASE_REF" --json number,headRefOid -q '.[]|"\(.number)\t\(.headRefOid)"')
else
echo "Chromium major versions match, nothing to do"
fi
70 changes: 70 additions & 0 deletions .github/workflows/sync-and-rebase-pr-from-fork.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
name: Sync and rebase PR from fork

on:
workflow_dispatch:
inputs:
PR_NUMBER:
required: true
description: "Number of the PR from the fork"

jobs:
sync-and-rebase-pr-from-fork:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
with:
fetch-depth: 0

- name: Setup Git
run: |
git config user.name brave-builds
git config user.email [email protected]
git config push.default simple

- name: Sync and rebase PR from fork
env:
GITHUB_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
PR_NUMBER: ${{ inputs.PR_NUMBER }}
run: |
set -x
JQ="jq -e -r"

gh_pr_view=$(gh pr view "$PR_NUMBER" --json baseRefName,headRefName,headRepository,headRepositoryOwner,id,isCrossRepository,url)

baseRefName=$($JQ ".baseRefName" <<<"$gh_pr_view")
headRefName=$($JQ ".headRefName" <<<"$gh_pr_view")
headRepositoryName=$($JQ ".headRepository.name" <<<"$gh_pr_view")
headRepositoryOwnerLogin=$($JQ ".headRepositoryOwner.login" <<<"$gh_pr_view")
isCrossRepository=$($JQ ".isCrossRepository" <<<"$gh_pr_view")
url=$($JQ ".url" <<<"$gh_pr_view")

[[ "$isCrossRepository" = "true" ]] || { echo "PR is not cross repo. Exiting!"; exit 1; }

git remote add contributor "https://github.com/$headRepositoryOwnerLogin/$headRepositoryName.git" || :
contribHeadRefName="contributor-$headRepositoryOwnerLogin-$headRefName"
git fetch --no-tags contributor +"$headRefName":"$contribHeadRefName"

# Rebase the branch with the latest targeting branch HEAD
git checkout "$contribHeadRefName"
git fetch origin "$baseRefName"
if ! git rebase FETCH_HEAD; then
echo "Rebase conflict detected. Please resolve the conflicts and push the changes to your fork. Exiting!"
exit 1
fi
git push -f origin "$contribHeadRefName"

existing_prs=$(gh pr list -H "$contribHeadRefName" --json number)
if [[ "$existing_prs" = "[]" ]]; then
gh pr create \
--draft \
--base "$baseRefName" \
--head "$contribHeadRefName" \
--assignee "$headRepositoryOwnerLogin" \
--title "CI run for contributor PR #$PR_NUMBER" \
--body \
"## Description
This PR is created to run CI on the changes proposed in PR #$PR_NUMBER by @$headRepositoryOwnerLogin.

**This PR should not be merged.**"
fi
50 changes: 0 additions & 50 deletions .github/workflows/sync-pr-from-fork.yml

This file was deleted.

Loading
Loading