Sign final keshav #74
Conversation
| onClick={handleVerifyButtonClick} | ||
| as={isVerified ? StyledVerified : isVerificationFailed ? StyledNotVerified : 'button'} | ||
| <Tooltip | ||
| text="Verification failed. Please check the document." |
There was a problem hiding this comment.
we are not showing any new information here. the tooltip should convey extra information about verification failure like there are no signatures on this document or the attached signature is not valid, etc.
| pdfFile={pdfFile} | ||
| onClick={handleVerifyButtonClick} | ||
| as={isVerified ? StyledVerified : isVerificationFailed ? StyledNotVerified : 'button'} | ||
| onMouseEnter={() => setShowVerificationTooltip(true)} |
There was a problem hiding this comment.
we don't need to use mouse events to show/hide tooltip. we could have also used css hover properties to show hide tooltip. otherwise we would have to create so many states.
But we can go with this for now as well
There was a problem hiding this comment.
Or we could move these states to the tooltip component as well. that would be easy and clean up the code
| @@ -23,7 +23,7 @@ | |||
| display: flex; | |||
| flex-direction: column; | |||
| gap: 10px; | |||
| height: ${p => p.selected ? '656px' : '390px'}; | |||
| height: ${p => p.selected ? 'fit-content' : 'fit-content'}; | |||
There was a problem hiding this comment.
if we are using the same property in both cases than we don't need the ternary operator
resolved the following issues:
!. Implemented the error popup, with proper error handling.
2. Implemented the inputPopup for pin input.
3. Hidden state of save button.
4. Other minor open bugs.