Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebranded Private Page and other changes #11

Closed
wants to merge 13 commits into from
4 changes: 2 additions & 2 deletions browser/brave_profile_prefs.cc
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,8 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
registry->RegisterBooleanPref(kBraveAutofillPrivateWindows, true);
// appearance
registry->RegisterBooleanPref(kShowBookmarksButton, true);
registry->RegisterBooleanPref(kShowSidePanelButton, true);
registry->RegisterBooleanPref(kLocationBarIsWide, false);
registry->RegisterBooleanPref(kShowSidePanelButton, false);
registry->RegisterBooleanPref(kLocationBarIsWide, true);
registry->RegisterBooleanPref(kMRUCyclingEnabled, false);
registry->RegisterBooleanPref(kTabsSearchShow, true);
registry->RegisterBooleanPref(kTabMuteIndicatorNotClickable, false);
Expand Down
4 changes: 2 additions & 2 deletions browser/resources/settings/brave_appearance_page/sidebar.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<style include="settings-shared iron-flex">
<!-- <style include="settings-shared iron-flex">
.border {
border-top: var(--cr-separator-line);
border-bottom: var(--cr-separator-line);
Expand Down Expand Up @@ -45,4 +45,4 @@
no-extension-indicator>
</controlled-radio-button>
</settings-radio-group>
</div>
</div> -->
4 changes: 3 additions & 1 deletion browser/ui/views/sidebar/sidebar_container_view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,9 @@ void SidebarContainerView::Init() {

AddChildViews();
UpdateToolbarButtonVisibility();
SetSidebarShowOption(GetSidebarService(browser_)->GetSidebarShowOption());
//setting default state to never
SetSidebarShowOption(ShowSidebarOption::kShowNever);
/*SetSidebarShowOption(GetSidebarService(browser_)->GetSidebarShowOption());*/
}

void SidebarContainerView::SetSidebarOnLeft(bool sidebar_on_left) {
Expand Down
4 changes: 2 additions & 2 deletions components/brave_new_tab_ui/containers/newTab/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { MAX_GRID_SIZE } from '../../constants/new_tab_ui'
import Settings, { TabType as SettingsTabType } from './settings'

import { BraveNewsContextProvider } from '../../components/default/braveNews/customize/Context'
import BraveNewsHint from '../../components/default/braveNews/hint'
// import BraveNewsHint from '../../components/default/braveNews/hint'
import SponsoredImageClickArea from '../../components/default/sponsoredImage/sponsoredImageClickArea'
import GridWidget from './gridWidget'

Expand Down Expand Up @@ -690,7 +690,7 @@ class NewTabPage extends React.Component<Props, State> {
</Page.Footer>
{newTabData.showToday &&
<Page.GridItemNavigationBraveNews>
<BraveNewsHint />
{/* <BraveNewsHint /> */} {/*Commented out to remove the Scroll for Brave News Tile*/}
</Page.GridItemNavigationBraveNews>
}
</Page.Page>
Expand Down

Large diffs are not rendered by default.

Binary file modified components/brave_welcome_ui/assets/[email protected]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye bhi toh last pr mein change kiya tha

Binary file not shown.
6 changes: 4 additions & 2 deletions components/brave_welcome_ui/components/help-improve/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ function HelpImprove () {
<S.MainBox>
<div className="view-header-box">
<div className="view-details">
<h1 className="view-title">{getLocale('braveWelcomeHelpImproveBraveTitle')}</h1>
<h1 className="view-title">
{getLocale('braveWelcomeHelpImproveBraveTitle')}
</h1>
</div>
</div>
<S.Grid>
Expand Down Expand Up @@ -104,7 +106,7 @@ function HelpImprove () {
</Button>
<S.FootNote>
{changeSettingsNote.beforeTag}
<a href="brave://settings/privacy" onClick={handleOpenSettingsPage}>
<a href="ping://settings/privacy" onClick={handleOpenSettingsPage}>
{changeSettingsNote.duringTag}
</a>
{changeSettingsNote.afterTag}
Expand Down
12 changes: 6 additions & 6 deletions components/brave_welcome_ui/stories/locale.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { provideStrings } from '../../../.storybook/locale'

provideStrings({
braveWelcomeTitle: 'Privacy. By Default.',
braveWelcomeDesc: 'Get Brave protection on every link you click. Just set Brave as default and browse. Privately.',
braveWelcomeDesc: 'Get Ping protection on every link you click. Just set Ping as default and browse. Privately.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this as well

braveWelcomeImportSettingsTitle: 'Import Settings',
braveWelcomeImportSettingsDesc: 'Easily import bookmarks, extensions, even saved passwords from your old browser.',
braveWelcomeSelectProfileLabel: 'Select profile to import',
Expand All @@ -18,16 +18,16 @@ provideStrings({
braveWelcomeBackButtonLabel: 'Back',
braveWelcomeNextButtonLabel: 'Next',
braveWelcomeFinishButtonLabel: 'Finish',
braveWelcomeSetDefaultButtonLabel: 'Set Brave as default browser',
braveWelcomeSetDefaultButtonLabel: 'Set Ping as default browser',
braveWelcomeSelectAllButtonLabel: 'Select All',
braveWelcomeHelpImproveBraveTitle: 'Help make Brave better.',
braveWelcomeHelpImproveBraveTitle: 'Help make Ping better.',
braveWelcomeSendReportsLabel: 'Send diagnostic reports if you experience a crash or freeze. $1Learn more.$2',
braveWelcomeSendInsightsLabel: 'Share completely private and anonymous product insights about what features are being used by Brave\'s users. $1Learn more.$2',
braveWelcomeSendInsightsLabel: 'Share completely private and anonymous product insights about what features are being used by Ping\'s users. $1Learn more.$2',
braveWelcomeSetupCompleteLabel: 'Setup complete',
braveWelcomeChangeSettingsNote: ' Change these choices at any time in Brave at $1brave://settings/privacy$2.',
braveWelcomeChangeSettingsNote: ' Change these choices at any time in Ping at $1ping://settings/privacy$2.',
braveWelcomePrivacyPolicyNote: 'Read our full $1Privacy Policy$2',
braveWelcomeSelectThemeLabel: 'Choose your theme',
braveWelcomeSelectThemeNote: 'You can change this at any time in Brave settings.',
braveWelcomeSelectThemeNote: 'You can change this at any time in Ping settings.',
braveWelcomeSelectThemeSystemLabel: 'Match system setting',
braveWelcomeSelectThemeLightLabel: 'Light mode',
braveWelcomeSelectThemeDarkLabel: 'Dark mode'
Expand Down
Binary file modified components/img/newtab/backgrounds/dylan-malval_sea-min.webp
Binary file not shown.
Loading
Loading